324449 - error when moving a tab before it's parent and then closing it (Error: uncaught exception: 2147500037)

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060123 Firefox/1.6a1 ID:2006012310 (in -safe-mode)

reproduce:
1. Open Firefox
2. Open 2 blank tabs
3. Open a 3rd blank tab and drag it between the first 2
4. Close that tab

result:
- You can not select any tabs
- You'll only see a gray empty window
- JS Console -> Error: uncaught exception: 2147500037

Comment 1

[Peter van der Woude [:Peter6]]

If you furthermode try to load a bookmark into the dead tabs the console shows

Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULElement.boxObject]
Source file: chrome://global/content/bindings/browser.xml

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Confirmed: the problem is that the owner focusing code gets the owners index before closing the tab. The index to focus is then invalid after closing the tab.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: find the tab to focus after removing the old tab

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: better patch

Change the comments too.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 209409 [details] [diff] [review]
better patch

I understand my code is a little confusing here. Inside the first for loop (//remove this tab as the owner ...) before the var tab = maybe also add a comment: 

// |tab| refers to any tab owned by the tab being removed. 

r=[e-mail]

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Fixed on the trunk.
mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.127;

Comment 7

[:Gavin Sharp [email: [e-mail]]]

fixed on the branch by bug 329054

Comment 8

[Tracy Walker [:tracy]]

Verified fixed with Windows, Mac and Linux with 2.0.b1rc3 builds