324536 - The info bar pops into existence too suddenly and is easy to miss as a result

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

The info bar should not appear suddenly.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: slide in from the top

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 209462 [details] [diff] [review]
slide in from the top

Hot.
It seems a little slow on OS X (haven't tried on w32). Maybe twice as fast? We probably want the entire thing to slide out within 1s.

Speed problems aside, this is great.

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #2)
> (From update of attachment 209462 [details] [diff] [review] [edit])
> Hot.
> It seems a little slow on OS X (haven't tried on w32). Maybe twice as fast? We
> probably want the entire thing to slide out within 1s.
> 
> Speed problems aside, this is great.
> 

Try replacing |curHeight += 1;| with curHeight += 2 or 3.  Even if that makes it 1-2px too tall for a moment, it should be imperceptible to the user (since the onunderflow will fire immediately after that).

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

cc'ing vlad: this is the sort of thing that I'm hoping we'll be able to do a lot more cleanly with Cairo. CTho's solution, depite being the right UI idea, feels kinda sluggish and hacky to me when I run it.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Neil Deakin worked some XUL magic and got the animation working really nicely (at least on w32, I assume it works on all platforms). CCing him on this bug so he has a sensible place to submit a patch.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 209462 [details] [diff] [review]
slide in from the top

The new notificationbox widget does this.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Does that also make this bug a duplicate/invalid/fixed?

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Fixed by Enn in bug 268590.