324611 - Bold is not bold in Cairo (<b> and <strong> tags don't work)

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Ria Klaassen (not reading all bugmail)]

For some reason Cairo displays bold text as normal text.
It doesn't react to <b></b>

<b><img src="/img/pijl_trans.gif" alt="" border="0" height="9" hspace="4" vspace="0" width="4"> 

<a class="link" href="/news/662409/10/Ongevallen_door_spekgladde_wegen.html">
Ongevallen door spekgladde wegen</a>
</b>

Comment 1

[Peter van der Woude [:Peter6]]

Attachment: testcase

Comment 2

[Peter van der Woude [:Peter6]]

Attachment: testcase

Comment 3

[Landon Abney]

It also doesnt react to the <strong> tag. Another thing: your second testcase actually shows bold text while everything else isn't.

Comment 4

[Peter van der Woude [:Peter6]]

Attachment: testcase

testcase with <b> and <strong> tag

Comment 5

[Ria Klaassen (not reading all bugmail)]

Please don't change the summary so drastically. Want to be able to recognize my own bugs. Thanks.

Comment 6

[Peter van der Woude [:Peter6]]

Ria, <span style="font-weight:bold"> ... </span> works fine in Cairo builds so the current discription leaves room for misinterpretation.
That's why I changed it.

Comment 7

[Ria Klaassen (not reading all bugmail)]

The first two lines of comment #0 leave no room for misunderstanding.
There are no other bugs about bold text in Cairo. Editing the summary was not necessary. But thanks for the effort anyway.

Comment 8

[Peter van der Woude [:Peter6]]

temporary hack to get the bold letters:

add the following lines to userContent.css

b, strong {
 font-weight:bold !important;
}

Comment 9

[Jonathan Haas]

Attachment: testcase normal/bold/bolder

Firefox/Cairo does not seem to be able to understand "font-size:bolder"

(The default font-weight for <b> and <strong> is "bolder", not "bold".)

Comment 10

[Peter van der Woude [:Peter6]]

(In reply to comment #9)
> Created an attachment (id=213305) [edit]
> testcase normal/bold/bolder
> 
> Firefox/Cairo does not seem to be able to understand "font-size:bolder"
> 
> (The default font-weight for <b> and <strong> is "bolder", not "bold".)
> 
read:
http://www.mozilla.org/newlayout/testcases/css/fontproperties.html

Comment 11

[Jonathan Haas]

(In reply to comment #9)
> Firefox/Cairo does not seem to be able to understand "font-size:bolder"

Sorry, I meant "font-weight:bolder;"

Some other strage things:

font-weight:900 works
So the rendeing engine _can_ draw it.

font-weight:bolder in a font-weight:bold span is bold
If this would be a rendeing problem then probably there would be an normal unbold text.

So I suppose the bug is somewhere in the CSS-Parser or so and for some strange reason font-weight:bolder is ignored. When ispecting a font-weight:bolder span with DOMI, it says in the computed style "font-weight:401". That seems to be very stange abecause a bold text (not bolder) has really has "bold" as value in DOMI and 401 is a value that is even lighter than normal. (500 is default, 100 is very light, 900 is very bold).

Comment 12

[Stuart Parmenter]

Attachment: initial fix

this should fix most of the bold problems.  we need to do some global font cache thing on windows where we can cache this info so we don't have to GetTextMetrics, etc every time.

Comment 13

[Stuart Parmenter]

i'm gonna say this is fixed.

Comment 14

[u88484]

All the testcases WFM and a few websites I tried.

Comment 15

[Allie]

It also doesnt react to the <strong> tag. https://www.osteopaat-deklerk.nl/werkwijze

Comment 16

[Allie]

(In reply to Allie from comment #15)

It also doesnt react to the <strong> tag. https://www.osteopaat-deklerk.nl/werkwijze