Closed Bug 324645 Opened 15 years ago Closed 15 years ago

<a ping> support should be opt-in, not opt-out, for Gecko-based apps

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: bzbarsky, Assigned: darin.moz)

References

Details

Attachments

(1 file)

I think it would make more sense to have the C++ default to false, remove the "true" from all.js, and enable it per-app. This way embeddors won't accidentally ship ping enabled without user-visible UI for it...  Also, this way non-browser Gecko consumers won't be affected.
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
Flags: blocking1.9a1?
Blocks: 319368
Attached patch v1 patchSplinter Review
My recent patch to introduce nsIWebBrowserChrome2, also had the effect of disabling <a ping> by default in the code.  I decided to leave the pref defined in all.js so that it would appear in about:config in products where it is not explicitly defined.  Otherwise, this patch just moves the pref to firefox.js, so that it only affects firefox.
Attachment #210645 - Flags: superreview?(bzbarsky)
Attachment #210645 - Flags: review?(bzbarsky)
Attachment #210645 - Flags: superreview?(bzbarsky)
Attachment #210645 - Flags: superreview+
Attachment #210645 - Flags: review?(bzbarsky)
Attachment #210645 - Flags: review+
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: blocking1.9a1?
You need to log in before you can comment on or make changes to this bug.