<a ping> support should be opt-in, not opt-out, for Gecko-based apps

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
Document Navigation
RESOLVED FIXED
12 years ago
7 years ago

People

(Reporter: bz, Assigned: Darin Fisher)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I think it would make more sense to have the C++ default to false, remove the "true" from all.js, and enable it per-app. This way embeddors won't accidentally ship ping enabled without user-visible UI for it...  Also, this way non-browser Gecko consumers won't be affected.
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
(Reporter)

Updated

12 years ago
Flags: blocking1.9a1?
(Assignee)

Updated

12 years ago
Blocks: 319368
(Assignee)

Comment 1

12 years ago
Created attachment 210645 [details] [diff] [review]
v1 patch

My recent patch to introduce nsIWebBrowserChrome2, also had the effect of disabling <a ping> by default in the code.  I decided to leave the pref defined in all.js so that it would appear in about:config in products where it is not explicitly defined.  Otherwise, this patch just moves the pref to firefox.js, so that it only affects firefox.
Attachment #210645 - Flags: superreview?(bzbarsky)
Attachment #210645 - Flags: review?(bzbarsky)
(Reporter)

Updated

12 years ago
Attachment #210645 - Flags: superreview?(bzbarsky)
Attachment #210645 - Flags: superreview+
Attachment #210645 - Flags: review?(bzbarsky)
Attachment #210645 - Flags: review+
(Assignee)

Comment 2

12 years ago
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Reporter)

Updated

11 years ago
Flags: blocking1.9a1?
You need to log in before you can comment on or make changes to this bug.