Need to ship vc8 redist bits in the installer

RESOLVED FIXED

Status

()

Core
Build Config
P1
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Stuart Parmenter, Assigned: Benjamin Smedberg)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

12 years ago
We need to bundle the vc8 redist bits.

either:
	msvcm80.dll
	msvcp80.dll
	msvcr80.dll
	Microsoft.VC80.CRT.manifest
("You may also redistribute all the files (*.dll and *.manifest) within a folder, listed below the folder for your convenience, as an entire set.")

or vcredist_x86.exe (need to make sure it doesn't put up any UI or anything)
(Assignee)

Comment 1

12 years ago
Created attachment 210384 [details] [diff] [review]
Ship MSVC8 runtime libs in dist/bin, rev. 1
Attachment #210384 - Flags: review?
(Assignee)

Comment 2

12 years ago
Comment on attachment 210384 [details] [diff] [review]
Ship MSVC8 runtime libs in dist/bin, rev. 1

Paul, I added configure substitutions for MOZILLA_OFFICIAL, BUILD_OFFICIAL, and MOZ_MILESTONE_RELEASE as we discussed on IRC, so that they can be set in mozconfig and not need to be set in the tinderbox environment.
Attachment #210384 - Flags: review? → review?(preed)
(Assignee)

Updated

12 years ago
Priority: -- → P1

Comment 3

12 years ago
Comment on attachment 210384 [details] [diff] [review]
Ship MSVC8 runtime libs in dist/bin, rev. 1

Looks good!
(Assignee)

Comment 4

12 years ago
I'll take that as r=preed, fixed on trunk. Paul, you probably want to mark the review to get it out of your queue.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 5

12 years ago
Comment on attachment 210384 [details] [diff] [review]
Ship MSVC8 runtime libs in dist/bin, rev. 1

I'll remember all the details one of these days...
Attachment #210384 - Flags: review?(preed) → review+

Comment 6

12 years ago
Might it be this patch caused MOZILLA_OFFICIAL and/or BUILD_OFFICIAL to be enabled by default if it is not set? I build SeaMonkey on Windows with current Cygwin perl and now i have a Build ID: 2006020617 in the title bar (normally this was always 00000000).
Created attachment 211044 [details] [diff] [review]
quote-win32-redist-dir.patch

There's some funky quoting going on; to get the right things to happen in the makefile $(addprefix), the var needs to be stored with \ quotes around the spaces.  But that doesn't work for configure, so we have configure do the quoting.
Attachment #211044 - Flags: review?(benjamin)
(Assignee)

Comment 8

12 years ago
Comment on attachment 211044 [details] [diff] [review]
quote-win32-redist-dir.patch

Just put the |sed bits directly on WIN32_REDIST_DIR and don't bother with the _QUOTED variety.
Attachment #211044 - Flags: review?(benjamin)

Comment 9

12 years ago
Created attachment 211167 [details] [diff] [review]
Fixes MOZILLA_OFFICIAL issue (see Comment 6)

Updated

12 years ago
Attachment #211167 - Flags: review?(benjamin)
(Assignee)

Updated

12 years ago
Attachment #211167 - Flags: review?(benjamin) → review+
(In reply to comment #9)
> Created an attachment (id=211167) [edit]
> Fixes MOZILLA_OFFICIAL issue (see Comment 6)

checked in
Checking in config/Makefile.in;
/cvsroot/mozilla/config/Makefile.in,v  <--  Makefile.in
new revision: 3.124; previous revision: 3.123
done
You need to log in before you can comment on or make changes to this bug.