324846 - XUL links still being exposed as buttons

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Aaron Leventhal]

Apparently our fix for XUL links isn't working very well. The XUL links in the JS console and extension manager are being exposed as buttons, for example

Comment 1

[Aaron Leventhal]

Attachment: Make sure we CacheActionContent() and inherit link behavior

Still need to test on Windows.

Comment 2

[Aaron Leventhal]

Attachment: nsXULLinkAccessible should inherit from nsLinkableAccessible

Comment 3

[[e-mail]]

Comment on attachment 209887 [details] [diff] [review]
nsXULLinkAccessible should inherit from nsLinkableAccessible

>+  NS_IMETHOD Init();
It's not clear how this fits in.

Comment 4

[Aaron Leventhal]

Neil, we need to do CacheActionContent() in Init() instead of the constructor, because if we put the call in the nsLinkableAccessible constructor, believe it or not the wrong CacheActionContent() is called for an nsXULLinkAccessible. That's a virtual method. We want the nsXULLinkAccessible::CacheActionContent() to be called when the object is created, not nsLinkableAccessible::CacheActionContent().

Init() is always called for accessibles after they are created.

Comment 5

[[e-mail]]

Comment on attachment 209887 [details] [diff] [review]
nsXULLinkAccessible should inherit from nsLinkableAccessible

Sorry, I was momentarily confused by the location of the nsLinkableAccessible class definition being in nsBaseWidgetAccessible.h

Comment 6

[[e-mail]]

(In reply to comment #4)
>Neil, we need to do CacheActionContent() in Init() instead of the constructor,
>because if we put the call in the nsLinkableAccessible constructor, believe it
>or not the wrong CacheActionContent() is called for an nsXULLinkAccessible.
Actually that behaviour is correct for C++ - you don't get to call nsXULLinkAccessible's virtual methods until its constructor which runs after all of its base classes and members have been constructed.

Comment 7

[Aaron Leventhal]

Checking in src/base/nsBaseWidgetAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsBaseWidgetAccessible.cpp,v  <--  nsBaseWidgetAccessible.cpp
new revision: 1.43; previous revision: 1.42
done
Checking in src/base/nsBaseWidgetAccessible.h;
/cvsroot/mozilla/accessible/src/base/nsBaseWidgetAccessible.h,v  <--  nsBaseWidgetAccessible.h
new revision: 1.18; previous revision: 1.17
done
Checking in src/xul/nsXULTextAccessible.cpp;
/cvsroot/mozilla/accessible/src/xul/nsXULTextAccessible.cpp,v  <--  nsXULTextAccessible.cpp
new revision: 1.20; previous revision: 1.19
done
Checking in src/xul/nsXULTextAccessible.h;
/cvsroot/mozilla/accessible/src/xul/nsXULTextAccessible.h,v  <--  nsXULTextAccessible.h
new revision: 1.15; previous revision: 1.14
done

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381