325117 - libgtkmozembed no longer exists but still referenced in pkgconfig's seamonkey-gtkmozembed.pc

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P4)

Description

[Mitch]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060104 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060104 SeaMonkey/1.5a

It appears that libgtkmozembed.so no longer exists, but the pkgconfig file seamonkey-gtkmozembed.pc still references it. This breaks builds of other applications that uses mozilla's embedding engine.

This is my cvs build seamonkey-gtkmozembed.pc  file

% cat ./mozilla.objs/build/unix/seamonkey-gtkmozembed.pc
prefix=/usr/local
exec_prefix=/usr/local
libdir=/usr/local/lib/seamonkey-1.5a
includedir=/usr/local/include/seamonkey-1.5a

Name: Mozilla Gtk Embedding Widget
Description: Mozilla Embedding Widget for Gtk+
Version: 1.5a
Requires: seamonkey-xpcom = 1.5a
Libs: -L${libdir} -lgtkembedmoz 
Cflags: -I${includedir}/gtkembedmoz
home /usr/src/moz/mozilla% 

I guess we now need to use libembedcomponents.so amongst others ?


Reproducible: Always

Steps to Reproduce:




I've marked as major since it is a major feature that's broken.

Comment 1

[Benjamin Smedberg]

Attachment: Remove *-gtkmozembed.pc, rev. 1

gtkmozembed is no longer build with seamonkey. You will want to use the xulrunner pkgconfig flags (which I'm not sure exist or work correctly) to link with gtkmozembed symbols.

Comment 2

[Crispin Flowerday (not receiving bug mail)]

Assuming that the gtkmozembed API is still there, can't the .pc file be fixed ? (rather than removing it)

Comment 3

[Christian Persch (GNOME) (away; not receiving bug mail)]

Do all xulrunner builds have the gtkmozembed symbols in them, or is it an optional feature? (If so, we still need a way to check for it with pkg-config.)

Comment 4

[Benjamin Smedberg]

the gtkmozembed API is not part of seamonkey any longer

All release builds of XULRunner (GTK2) will contain gtkmozembed; it's probably disablable by config option but that won't ever be an issue in practice.

Comment 5

[Mitch]

Note this also affects gman (gnome manual page viewer), and yelp among others which also uses the embedding engine. 

I recompiled cvs cmonkey with --enable-application=xulrunner and now the gtk_moz_embed_xxx() functions are present in libxul.so and the link completes for epiphany.

I'm just unsure about the xulrunner build. So now i have code for seamonkey, xulrunner (only for libxul.so so that i can have the embedding engine) and also firefox and thunderbird. Massive code duplication or what ? Why can't libxul.so be built as part of the suite by default ? Or is there an compile time build option that i am missing ?

Comment 6

[Benjamin Smedberg]

> I'm just unsure about the xulrunner build. So now i have code for seamonkey,
> xulrunner (only for libxul.so so that i can have the embedding engine) and also
> firefox and thunderbird. Massive code duplication or what ? Why can't libxul.so

No, you should only need to code for gtkmozembed on xulrunner (and it's the same codebase anyway)... Firefox and Thunderbird will be built on top of XULRunner, and seamonkey is less important and may or may not move over to the XULRunner/toolkit world.

Comment 7

[Benjamin Smedberg]

Fixed on trunk.