325307 - infinite loop in SECU_FindCrlIssuer

Status: RESOLVED FIXED

(NSS :: Tools, defect)

Description

[Alexei Volkov]

The function will be executed indefinitely since the "node" is not switched to the
next in a list in the "while" loop body.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Alexei, thanks for finding these bugs.  
Since you've done the hard work (finding the bugs), 
please attach patches to fix them.

Comment 2

[Alexei Volkov]

Attachment: patch

change "node" to next if node's cert is not the signing cert.
also changing program flow in the loop to avoid goto.

Comment 3

[Wan-Teh Chang]

Comment on attachment 210407 [details] [diff] [review]
patch

r=wtc.  I like the elimination of the unnecessary
goto statement.  One suggested improvement: the
nested if statements can be combined into one.

Comment 4

[Alexei Volkov]

Attachment: patch

code got cleaned up a little more.

Comment 5

[Wan-Teh Chang]

Comment on attachment 210429 [details] [diff] [review]
patch

>+                CERT_IsUserCert(cert) == PR_TRUE) {

When testing a boolean, our preferred style is to
omit == PR_TRUE, != PR_TRUE, == PR_FALSE, and
!= PR_FALSE.

Comment 6

[Alexei Volkov]

Checking in secutil.c;
/cvsroot/mozilla/security/nss/cmd/lib/secutil.c,v  <--  secutil.c
new revision: 1.71.2.1; previous revision: 1.71
done
Checking in secutil.c;
/cvsroot/mozilla/security/nss/cmd/lib/secutil.c,v  <--  secutil.c
new revision: 1.72; previous revision: 1.71
done

Comment 7

[Wan-Teh Chang]

Comment on attachment 210429 [details] [diff] [review]
patch

Good code cleanup.

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

Backported rest of fix to NSS_3_11_BRANCH
Checking in lib/secutil.c;  new revision: 1.71.2.2; previous revision: 1.71.2.1