325410 - Mac builds not packaging .chk files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Mentovai]

The packager is not producing .chk files for Mac builds, because it's not finding the NSS libraries.  This should be fixed immediately on the trunk and all branches.

Comment 1

[Mark Mentovai]

Attachment: Fix paths to shlibsign for Mac builds

Comment 2

[Mark Mentovai]

Comment on attachment 210322 [details] [diff] [review]
Fix paths to shlibsign for Mac builds

(The NO_PKG_FILES ifdefs are because I override that variable, setting it to empty, during Camino packaging.)

Comment 3

[Mark Mentovai]

Attachment: Fix paths to shlibsign for Mac builds

Realized that _BINPATH allows the removals stuff to be collapsed too.

Comment 4

[Benjamin Smedberg]

Comment on attachment 210324 [details] [diff] [review]
Fix paths to shlibsign for Mac builds

>Index: mozilla/toolkit/mozapps/installer/packager.mk

>+ifdef NO_PKG_FILES
>+	cd $(DIST)/$(MOZ_PKG_APPNAME)$(_BINPATH); rm -rf $(NO_PKG_FILES)
>+endif

Why the ifdef? We set NO_PKG_FILES in this makefile, so it's never going to be empty...

Comment 5

[Mark Mentovai]

See comment 2

Comment 6

[Benjamin Smedberg]

oh... why do you do that? Be very careful because you could end up accidentally shipping LGPL code (xpidl).

Comment 7

[Mark Mentovai]

Camino.app is produced entirely in Xcode from a clean slate by hand-picking the files that we do want to package.  We don't bring everything in from $(DIST)/bin.

The reason I override it, from camino/installer/Makefile.in:

# packager.mk has its own exclude list that's appropriate for toolkit apps
# but not appropriate for the Xcode-built Camino.  Specifically, it excludes
# the files produced by Camino.app/Contents/MacOS/Camino -autoRegister YES,
# although they belong in the package.  Override.
NO_PKG_FILES=

The Camino build script registers components after the build and before packaging.

Comment 8

[Mark Mentovai]

Checked in on the trunk and Camino 1.0 branch.  Nominating for other branches because .chk files are required for FIPS mode.  http://www.mozilla.org/projects/security/pki/nss/tech-notes/tn6.html

Comment 9

[Wan-Teh Chang]

Comment on attachment 210324 [details] [diff] [review]
Fix paths to shlibsign for Mac builds

Mark, could you check this patch in on the MOZILLA_1_8_BRANCH?

This patch would need to be adjusted for the
MOZILLA_1_8_0_BRANCH because the names of the
NSS files that need to be signed are different
on that branch.

Comment 10

[Mark Mentovai]

Checked in to MOZILLA_1_8_BRANCH.

Comment 11

[Mark Mentovai]

Attachment: Fix paths, 1_8_0 branch version

This is the same patch as above, adjusted for the 1_8_0 branch.

This patch is highly recommended: it generates and packages .chk files, a requirement for NSS to operate in FIPS mode.

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 212543 [details] [diff] [review]
Fix paths, 1_8_0 branch version

approved for 180 branch, a=dveditz for drivers

Comment 13

[Mark Mentovai]

Fixed on 1_8_0.