Mac builds not packaging .chk files

RESOLVED FIXED

Status

()

Core
Build Config
--
critical
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Mark Mentovai, Assigned: Mark Mentovai)

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
PowerPC
Mac OS X
fixed1.8.0.2, fixed1.8.1
Points:
---
Bug Flags:
blocking1.8.0.2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [camino-1.0])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

12 years ago
The packager is not producing .chk files for Mac builds, because it's not finding the NSS libraries.  This should be fixed immediately on the trunk and all branches.
(Assignee)

Comment 1

12 years ago
Created attachment 210322 [details] [diff] [review]
Fix paths to shlibsign for Mac builds
Attachment #210322 - Flags: review?(benjamin)
(Assignee)

Comment 2

12 years ago
Comment on attachment 210322 [details] [diff] [review]
Fix paths to shlibsign for Mac builds

(The NO_PKG_FILES ifdefs are because I override that variable, setting it to empty, during Camino packaging.)
(Assignee)

Comment 3

12 years ago
Created attachment 210324 [details] [diff] [review]
Fix paths to shlibsign for Mac builds

Realized that _BINPATH allows the removals stuff to be collapsed too.
Attachment #210322 - Attachment is obsolete: true
Attachment #210324 - Flags: review?(benjamin)
Attachment #210322 - Flags: review?(benjamin)
Comment on attachment 210324 [details] [diff] [review]
Fix paths to shlibsign for Mac builds

>Index: mozilla/toolkit/mozapps/installer/packager.mk

>+ifdef NO_PKG_FILES
>+	cd $(DIST)/$(MOZ_PKG_APPNAME)$(_BINPATH); rm -rf $(NO_PKG_FILES)
>+endif

Why the ifdef? We set NO_PKG_FILES in this makefile, so it's never going to be empty...
Attachment #210324 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

12 years ago
See comment 2
oh... why do you do that? Be very careful because you could end up accidentally shipping LGPL code (xpidl).
(Assignee)

Comment 7

12 years ago
Camino.app is produced entirely in Xcode from a clean slate by hand-picking the files that we do want to package.  We don't bring everything in from $(DIST)/bin.

The reason I override it, from camino/installer/Makefile.in:

# packager.mk has its own exclude list that's appropriate for toolkit apps
# but not appropriate for the Xcode-built Camino.  Specifically, it excludes
# the files produced by Camino.app/Contents/MacOS/Camino -autoRegister YES,
# although they belong in the package.  Override.
NO_PKG_FILES=

The Camino build script registers components after the build and before packaging.
(Assignee)

Updated

12 years ago
Attachment #210324 - Flags: approval1.8.0.2?
(Assignee)

Comment 8

12 years ago
Checked in on the trunk and Camino 1.0 branch.  Nominating for other branches because .chk files are required for FIPS mode.  http://www.mozilla.org/projects/security/pki/nss/tech-notes/tn6.html
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Whiteboard: [camino-1.0]
(Assignee)

Updated

11 years ago
Blocks: 327848

Comment 9

11 years ago
Comment on attachment 210324 [details] [diff] [review]
Fix paths to shlibsign for Mac builds

Mark, could you check this patch in on the MOZILLA_1_8_BRANCH?

This patch would need to be adjusted for the
MOZILLA_1_8_0_BRANCH because the names of the
NSS files that need to be signed are different
on that branch.
Attachment #210324 - Flags: review+
Attachment #210324 - Flags: approval-branch-1.8.1+
(Assignee)

Comment 10

11 years ago
Checked in to MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
(Assignee)

Comment 11

11 years ago
Created attachment 212543 [details] [diff] [review]
Fix paths, 1_8_0 branch version

This is the same patch as above, adjusted for the 1_8_0 branch.

This patch is highly recommended: it generates and packages .chk files, a requirement for NSS to operate in FIPS mode.
Attachment #212543 - Flags: approval1.8.0.2?
(Assignee)

Updated

11 years ago
Attachment #210324 - Flags: approval1.8.0.2?

Updated

11 years ago
Attachment #212543 - Flags: review+
Flags: blocking1.8.0.2+
Comment on attachment 212543 [details] [diff] [review]
Fix paths, 1_8_0 branch version

approved for 180 branch, a=dveditz for drivers
Attachment #212543 - Flags: approval1.8.0.2? → approval1.8.0.2+
(Assignee)

Comment 13

11 years ago
Fixed on 1_8_0.
Keywords: fixed1.8.0.2
You need to log in before you can comment on or make changes to this bug.