325471 - Broken search for path to binary on linux in xulrunner-stub

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Pawel Chmielowski]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060131 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060131 Firefox/1.6a1

Current method of searching for real path to xulrunner-stub in somewhat broken. First it can lead to infinite loop, and also doesn't resolve symlinks for paths from PATH.

I attach patch shortly.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Pawel Chmielowski]

Attachment: v1

This fixes infinite loop, and add symlinks resolving to xulrunner-stub

Comment 2

[Benjamin Smedberg]

Comment on attachment 210366 [details] [diff] [review]
v1

Could you provide a patch that does the same thing for the apprunner?

http://lxr.mozilla.org/mozilla/source/toolkit/xre/nsAppRunner.cpp#1122

The tokenizing there is correct, but it should probably use realpath as you do here.

Comment 3

[Pawel Chmielowski]

Attachment: v2

This patches also nsAppRunner.cpp

Comment 4

[Benjamin Smedberg]

Comment on attachment 210371 [details] [diff] [review]
v2

>     while ( (token = nsCRT::strtok(newStr, ":", &newStr)) ) {
>       sprintf(exePath, "%s/%s", token, argv0);
>-      if (stat(exePath, &fileStat) == 0) {
>+      if (realpath(tmpPath, exePath) && stat(exePath, &fileStat) == 0) {
>         found = PR_TRUE;
>         break;
>       }

You mean to change the sprintf to point to tmpPath, right?

Comment 5

[Pawel Chmielowski]

Attachment: v3

(In reply to comment #4)
> You mean to change the sprintf to point to tmpPath, right?
> 

Right.

Comment 6

[Benjamin Smedberg]

Comment on attachment 210374 [details] [diff] [review]
v3

r=me, get somebody on irc.mozilla.org #developers to land this. I'll grant 1.8.1 once we verify this works on trunk: 1.8.0.2 depends on getting some decent QA for this.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Landed by timeless on the trunk.
mozilla/toolkit/xre/nsAppRunner.cpp 	1.126 	mozilla/xulrunner/stub/nsXULStub.cpp 	1.5 

Comment 8

[Benjamin Smedberg]

This is a low-risk patch and I really want the xulrunner-stub bits for 1.8.0.3. The firefox-bin parts are not a big deal because we always launch firefox-bin with the shell script which passes the full path as argv[0].

Comment 9

[Jay Patel [:jay]]

Comment on attachment 210374 [details] [diff] [review]
v3

Please check in promptly on the 1.8.0 branch.  Thanks!

Comment 10

[Benjamin Smedberg]

Fixed on 1.8.0