325487 - admin pages should require less "clicks" (remove useless confirmation pages)

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement, P1)

Description

[Frédéric Buclin]

When administering Bugzilla, you get a lot of these "OK, done" or "The product 'foo' has been updated" pages, which display no useful information. The best example is editgroups.cgi where adding/editing/deleting a group simply shows a "OK, done" and nothing else! And so when you want to set group inheritance correctly for a newly created group, you have to click the "back to the group list" link, and then edit the group you just created. Two clicks! And you still haven't edited anything at this point. This is consuming my patience.

What I suggest is to remove all these created | updated | deleted .html.tmpl pages and replace them by more useful messages at the top of the next pages, as we actually do when editing a user account from editusers.cgi or parameters from editparams.cgi. In other words, redisplay the page you just left or, in the case of a deletion, go back to the list.

This bug is about *all* edit*.cgi pages.

Gavin, Marc, is that something you are interested in?

Comment 1

[GavinS]

(In reply to comment #0)
> Gavin, Marc, is that something you are interested in?
> 
Yes. I've wanted to copy the way Marc's editusers pages work for a while. I'm trying to get back to some BZ stuff this month

Comment 2

[Frédéric Buclin]

Nice! So I'm pretty optimistic to see this being done for 2.24. We could make this topic (do more things in less clicks) one of our priority about UI rework. I hope you can join tomorrow for our IRC meeting. ;)

Comment 3

[Frédéric Buclin]

(In reply to comment #1)
> Yes. I've wanted to copy the way Marc's editusers pages work for a while. I'm
> trying to get back to some BZ stuff this month

This was 3 months ago. GavinS, are you still trying to work on it? :)

Comment 4

[Frédéric Buclin]

This bug is retargetted to Bugzilla 3.2 for one of the following reasons:

- it has no assignee (except the default one)
- we don't expect someone to fix it in the next two weeks (i.e. before we freeze the trunk to prepare Bugzilla 3.0 RC1)
- it's not a blocker

If you are working on this bug and you think you will be able to submit a patch in the next two weeks, retarget this bug to 3.0.

If this bug is something you would like to see implemented in 3.0 but you are not a developer or you don't think you will be able to fix this bug yourself in the next two weeks, please *do not* retarget this bug.

If you think this bug should absolutely be fixed before we release 3.0, either ask on IRC or use the "blocking3.0 flag".

Comment 5

[Frédéric Buclin]

That's still something I really want for 3.2. Some intermediate pages are really useless! I will try to have it ready for new year.

Comment 6

[Frédéric Buclin]

Attachment: patch, v1

Here we go. 23 templates (i.e. intermediate pages) removed!

Comment 7

[Max Kanat-Alexander]

Comment on attachment 295149 [details] [diff] [review]
patch, v1

This actually *looks* fine to me, but I'd still like reed or somebody to go over it more carefully and test it and give any feedback.

Comment 8

[Frédéric Buclin]

reed, justdave: my patch is applied to https://landfill.bugzilla.org/bz325487/ so that you can easily test it.

Comment 9

[Frédéric Buclin]

Vlad, have you time to review this one?

Comment 10

[Reed Loden [:reed]]

https://landfill.bugzilla.org/bz325487/editproducts.cgi?action=add only shows two classifications while https://landfill.bugzilla.org/bz325487/editclassifications.cgi shows three.

Just because the classification is empty, it should still show up on editproducts.cgi as a potential choice.

More to come... :)

Comment 11

[Max Kanat-Alexander]

This is so close to complete that it'd be silly to *not* block on it.

Comment 12

[Ron]

Attachment: test

Comment 13

[Frédéric Buclin]

Comment on attachment 297847 [details]
test

stupido!

Comment 14

[GavinS]

(It's been a while since I've reviewed anything, so I'm not doing any
r- ing, but I think most of these isues should be addressed)

1) Adding a new classification does not take you to the classification
   just created. (It does take you back to the list of
   classifications, which is OK, but perhaps it should present the
   classification for assigning products?)

2) Updating a product does not return you to the edit product

3) These is now sometimes confusion between the <title> of the html
   page, and what it displays. e.g. The <title> may be 'Component
   Deleted', but what is actually displayed is a list of components
   (and a message saying that one has been deleted). This can look
   odd. Perhaps the <title> should 'Editing compoents of Product XYZ',
   or perhaps 'Select component of product XYZ'

4) Update group access control does not return you to the edit group
   access controls page, or the edit product page

5) After adding a group, the list of groups is shown - should this be
   the group just added?

6) Regarding the "All references to bugs being in this component have
   also been deleted." message. We actually deleted the bugs as well,
   didn't we, so the message could say "All bugs in this component
   were deleted", or "All bugs and references to them have also been
   deleted" (Simiilarly for products)

7) The repeated display styling for the 'admin_item_that_was_editted'
   should be done via css, and not hard coded to <em></em>

8) Lastly, on the main admin page listing all the things it is
   possible to administrate, there could be some helper links, that
   would avoid some clicks, which is what this bug is all
   about. e.g. There could be links to add_classification,
   add_keyword, add_group, etc.

Comment 15

[Frédéric Buclin]

(In reply to comment #14)
> 1) Adding a new classification does not take you to the classification
>    just created. (It does take you back to the list of
>    classifications, which is OK, but perhaps it should present the
>    classification for assigning products?)

Fixed. You now get the "reclassify" page.


> 2) Updating a product does not return you to the edit product

That's intentional, due to votes. If you change vote settings, you may generate a lot of messages, such as "votes removed from [e-mail]", "bug xxx has been confirmed by popular votes", etc... Having a full screen of such messages with the edit form below it doesn't make sense nor is nice. So that's not something I plan to fix.


> 3) These is now sometimes confusion between the <title> of the html
>    page, and what it displays.

That's also intentional. I want the page title to reflect what just happened, in the same way process_bug.cgi displays "bug processeed" despite showing the same UI as when accessed from show_bug.cgi. What would be confusing IMO is to not indicate what just happened. Also something I don't plan to fix.


> 4) Update group access control does not return you to the edit group
>    access controls page, or the edit product page

Again intentional. I have ~10 groups, and I know installations such as b.m.o have much more. When you edit group settings. You get a long list of groups which what happened to them ("removed 10 bugs from group foo", "added 187 bugs to group bar", ...). Here again, having to scroll down this long list to view the product again doesn't make sense to me. If we really want it to go back to the edit form anyway, I would prefer to do it in a separate bug.


> 5) After adding a group, the list of groups is shown - should this be
>    the group just added?

This was the old behavior, i.e. having a link to go back to the list. But I'm not against implementing it this way. Fixed.


> 6) Regarding the "All references to bugs being in this component have
>    also been deleted." message. We actually deleted the bugs as well,
>    didn't we, so the message could say "All bugs in this component
>    were deleted", or "All bugs and references to them have also been
>    deleted" (Simiilarly for products)

Fixed.


> 7) The repeated display styling for the 'admin_item_that_was_editted'
>    should be done via css, and not hard coded to <em></em>

Bah, this is done this way in many other places already. At least I'm consistent. If you want a class for it, please file a separate bug.


> 8) Lastly, on the main admin page listing all the things it is
>    possible to administrate, there could be some helper links, that
>    would avoid some clicks, which is what this bug is all
>    about. e.g. There could be links to add_classification,
>    add_keyword, add_group, etc.

You don't necessarily want to add new stuff. I suppose you most of the time want to edit things. I don't want to clutter the UI with such links, at least not as part of this bug.



(In reply to comment #10)
> Just because the classification is empty, it should still show up on
> editproducts.cgi as a potential choice.

AFAIK, this is not a regression due to my patch. editproducts.cgi calls Bugzilla->user->get_selectable_classifications to get the list of classifications to display, which itself calls Bugzilla->user->get_selectable_products. If a classification has no product, then there is none selectable in it and so is not itself seen as a selectable classification. If you want this, you should file a separate bug as it requires more investigation (which behaviors will change, will this break something else?).

New patch coming in a few seconds as I cannot reply *and* attach a new patch at the same time.

Comment 16

[Frédéric Buclin]

Attachment: patch, v2

Per my previous comment.

Comment 17

[Frédéric Buclin]

FYI, bz325487 on landfill has the new patch applied, see the URL field.

Comment 18

[Dave Miller [:justdave]]

Comment on attachment 299032 [details] [diff] [review]
patch, v2

Structural integrity of this patch is great, I can't find any issues with it.

I have a couple minor ideas for additional ways to make the functionality easier, but those can be additional steps in new bugs if we care. :) This is much better than what we already had anyway.

Comment 19

[Frédéric Buclin]

Checking in editclassifications.cgi;
/cvsroot/mozilla/webtools/bugzilla/editclassifications.cgi,v  <--  editclassifications.cgi
new revision: 1.30; previous revision: 1.29
done
Checking in editcomponents.cgi;
/cvsroot/mozilla/webtools/bugzilla/editcomponents.cgi,v  <--  editcomponents.cgi
new revision: 1.86; previous revision: 1.85
done
Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.53; previous revision: 1.52
done
Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.88; previous revision: 1.87
done
Checking in editkeywords.cgi;
/cvsroot/mozilla/webtools/bugzilla/editkeywords.cgi,v  <--  editkeywords.cgi
new revision: 1.45; previous revision: 1.44
done
Checking in editmilestones.cgi;
/cvsroot/mozilla/webtools/bugzilla/editmilestones.cgi,v  <--  editmilestones.cgi
new revision: 1.62; previous revision: 1.61
done
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.139; previous revision: 1.138
done
Checking in editsettings.cgi;
/cvsroot/mozilla/webtools/bugzilla/editsettings.cgi,v  <--  editsettings.cgi
new revision: 1.11; previous revision: 1.10
done
Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v  <--  editvalues.cgi
new revision: 1.29; previous revision: 1.28
done
Checking in editversions.cgi;
/cvsroot/mozilla/webtools/bugzilla/editversions.cgi,v  <--  editversions.cgi
new revision: 1.58; previous revision: 1.57
done
Removing template/en/default/admin/classifications/delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/delete.html.tmpl,v  <--  delete.html.tmpl
new revision: delete; previous revision: 1.3
done
Removing template/en/default/admin/classifications/new.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/new.html.tmpl,v  <--  new.html.tmpl
new revision: delete; previous revision: 1.3
done
Removing template/en/default/admin/classifications/update.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/update.html.tmpl,v  <--  update.html.tmpl
new revision: delete; previous revision: 1.3
done
Removing template/en/default/admin/components/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/created.html.tmpl,v  <--  created.html.tmpl
new revision: delete; previous revision: 1.3
done
Removing template/en/default/admin/components/deleted.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/deleted.html.tmpl,v  <--  deleted.html.tmpl
new revision: delete; previous revision: 1.5
done
Removing template/en/default/admin/components/updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/updated.html.tmpl,v  <--  updated.html.tmpl
new revision: delete; previous revision: 1.9
done
Removing template/en/default/admin/fieldvalues/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/created.html.tmpl,v  <--  created.html.tmpl
new revision: delete; previous revision: 1.7
done
Removing template/en/default/admin/fieldvalues/deleted.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/deleted.html.tmpl,v  <--  deleted.html.tmpl
new revision: delete; previous revision: 1.5
done
Removing template/en/default/admin/fieldvalues/updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/updated.html.tmpl,v  <--  updated.html.tmpl
new revision: delete; previous revision: 1.6
done
Removing template/en/default/admin/groups/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/created.html.tmpl,v  <--  created.html.tmpl
new revision: delete; previous revision: 1.2
done
Removing template/en/default/admin/groups/deleted.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/deleted.html.tmpl,v  <--  deleted.html.tmpl
new revision: delete; previous revision: 1.4
done
Removing template/en/default/admin/groups/remove.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/remove.html.tmpl,v  <--  remove.html.tmpl
new revision: delete; previous revision: 1.4
done
Removing template/en/default/admin/keywords/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/created.html.tmpl,v  <--  created.html.tmpl
new revision: delete; previous revision: 1.3
done
Removing template/en/default/admin/keywords/rebuild-cache.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/rebuild-cache.html.tmpl,v  <--  rebuild-cache.html.tmpl
new revision: delete; previous revision: 1.5
done
Removing template/en/default/admin/milestones/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/milestones/created.html.tmpl,v  <--  created.html.tmpl
new revision: delete; previous revision: 1.4
done
Removing template/en/default/admin/milestones/deleted.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/milestones/deleted.html.tmpl,v  <--  deleted.html.tmpl
new revision: delete; previous revision: 1.6
done
Removing template/en/default/admin/milestones/updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/milestones/updated.html.tmpl,v  <--  updated.html.tmpl
new revision: delete; previous revision: 1.5
done
Removing template/en/default/admin/products/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/created.html.tmpl,v  <--  created.html.tmpl
new revision: delete; previous revision: 1.4
done
Removing template/en/default/admin/products/deleted.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/deleted.html.tmpl,v  <--  deleted.html.tmpl
new revision: delete; previous revision: 1.5
done
Checking in template/en/default/admin/settings/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/settings/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Removing template/en/default/admin/settings/updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/settings/updated.html.tmpl,v  <--  updated.html.tmpl
new revision: delete; previous revision: 1.4
done
Removing template/en/default/admin/versions/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/versions/created.html.tmpl,v  <--  created.html.tmpl
new revision: delete; previous revision: 1.4
done
Removing template/en/default/admin/versions/deleted.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/versions/deleted.html.tmpl,v  <--  deleted.html.tmpl
new revision: delete; previous revision: 1.5
done
Removing template/en/default/admin/versions/updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/versions/updated.html.tmpl,v  <--  updated.html.tmpl
new revision: delete; previous revision: 1.5
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v  <--  messages.html.tmpl
new revision: 1.69; previous revision: 1.68
done

Comment 20

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.