Closed Bug 325509 Opened 14 years ago Closed 14 years ago

add -no-remote switch to disable remote stuff

Categories

(Toolkit :: Startup and Profile System, enhancement)

1.8 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla1.8.1alpha2

People

(Reporter: logan+mozilla-bmo, Assigned: logan+mozilla-bmo)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

1.05 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
Sometimes it's more convenient to just use a switch.
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #210420 - Flags: review?(benjamin)
Comment on attachment 210420 [details] [diff] [review]
patch v1

If we're going to do this we should do it earlier in XRE_main, call CheckArg and set the environment variable. That will work for win32 as well as xremote and it will also work in various restart scenarios.
Attachment #210420 - Flags: review?(benjamin) → review-
Attached patch patch v2Splinter Review
Attachment #210420 - Attachment is obsolete: true
Attachment #210500 - Flags: review?(benjamin)
Attachment #210500 - Flags: review?(benjamin) → review+
Assignee: nobody → logan
Checked in on the trunk.
mozilla/toolkit/xre/nsAppRunner.cpp; new revision: 1.128;
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Comment on attachment 210500 [details] [diff] [review]
patch v2

It'd be nice to get this into 2.0 and 1.8.0.3 also. The trunk patch should apply with some fuzz.
Attachment #210500 - Flags: approval1.8.0.3?
Attachment #210500 - Flags: approval-branch-1.8.1?(benjamin)
Comment on attachment 210500 [details] [diff] [review]
patch v2

This is not 1.8.0 branch material.
Attachment #210500 - Flags: approval1.8.0.3?
Attachment #210500 - Flags: approval1.8.0.3-
Attachment #210500 - Flags: approval-branch-1.8.1?(benjamin)
Attachment #210500 - Flags: approval-branch-1.8.1+
Ok, fair enough. Thanks :)
Whiteboard: [checkin needed (1.8 branch)]
mozilla/toolkit/xre/nsAppRunner.cpp 	1.113.2.11
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Firefox 3 → Firefox 2 alpha2
Version: Trunk → 2.0 Branch
Blocks: 361085
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.