325556 - update-packaging doesn't properly reference dependent binaries

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[timeless]

62         MAR=$(DIST)/host/bin/mar \
   69         MAR=$(DIST)/host/bin/mar \
  51 HOST_PROGRAM    = mar$(HOST_BIN_SUFFIX)

Comment 1

[timeless]

Attachment: use suffix

Comment 2

[Darin Fisher]

Comment on attachment 210459 [details] [diff] [review]
use suffix

r=darin

Comment 3

[J. Paul Reed [:preed]]

This is actually a problem for MBSDIFF as well (for make_incremental_update.sh).

I'll combine these patches in a sec...

Comment 4

[J. Paul Reed [:preed]]

Attachment: use suffix patch + specify mbsdiff explicitely patch

Comment 5

[Darin Fisher]

Comment on attachment 214371 [details] [diff] [review]
use suffix patch + specify mbsdiff explicitely patch

r+a=darin

Comment 6

[J. Paul Reed [:preed]]

Checked in on the trunk; do the branches need this?

I'm pretty sure we only use these tools on the trunk (whether or not it's *supposed* to be like that is another issue altogether...)

Comment 7

[Darin Fisher]

I recall chase landing fixes on the 1.8 branch for various update tooling issues.  It is probably a good idea to keep the code in sync since others (e.g., mkaply) are using these tools as well.

Comment 8

[J. Paul Reed [:preed]]

This was checked in on 1.8 a long time ago; 1.8.0 doesn't seem to need it, because the makefile infrastructure there doesn't have a target for partial patches, and therefore doesn't have a requirement to use mbsdiff from the build system.