Last Comment Bug 325592 - sunbird doesn't compile on 1.8-branch
: sunbird doesn't compile on 1.8-branch
Product: Calendar
Classification: Client Software
Component: Sunbird Only (show other bugs)
: Trunk
: x86 Windows XP
: -- normal (vote)
: ---
Assigned To: Michael Büttner (no reviews TFN)
Depends on:
  Show dependency treegraph
Reported: 2006-02-02 08:11 PST by Michael Büttner (no reviews TFN)
Modified: 2006-02-09 10:49 PST (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

proposed patch (1.06 KB, patch)
2006-02-02 08:24 PST, Michael Büttner (no reviews TFN)
benjamin: first‑review+
benjamin: approval‑branch‑1.8.1+
Details | Diff | Splinter Review

Description Michael Büttner (no reviews TFN) 2006-02-02 08:11:07 PST
sunbird doesn't compile on the 1.8-branch in dynamic builds. it tries to link against xul.lib which should be xulapp_s.lib instead.
Comment 1 Michael Büttner (no reviews TFN) 2006-02-02 08:24:02 PST
Created attachment 210479 [details] [diff] [review]
proposed patch

thanks to Michiel van Leeuwen for helping out on this one.
Comment 2 Stefan Sitter 2006-02-02 11:21:11 PST
Does Sunird build with this patch on MOZILLA_1_8_BRANCH on windows? When trying with cywin/mingw I still see the error as described in Bug 324170 Comment #22.
Comment 3 Michiel van Leeuwen (email: mvl+moz@) 2006-02-02 11:27:17 PST
That error is unrelated to this problem
Comment 4 Michiel van Leeuwen (email: mvl+moz@) 2006-02-09 10:49:46 PST
patch checked in

Note You need to log in before you can comment on or make changes to this bug.