325616 - Add recently developed ATK roles

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The ATK spec has some new roles. We should add those constants and support the ones which make sense.

Comment 1

[Aaron Leventhal]

Attachment: Add new roles, support caption and autocomplete

Comment 2

[[e-mail]]

Comment on attachment 210494 [details] [diff] [review]
Add new roles, support caption and autocomplete

>+  *aRole = boxName.Equals(NS_LITERAL_STRING("autocomplete")) ?
>+           ROLE_AUTOCOMPLETE : ROLE_COMBOBOX;
Nit: use .EqualsLiteral("autocomplete") instead. sr=me with this fixed.

Comment 3

[Aaron Leventhal]

Checking in public/nsIAccessible.idl;
/cvsroot/mozilla/accessible/public/nsIAccessible.idl,v  <--  nsIAccessible.idl
new revision: 1.42; previous revision: 1.41
done

Checking in src/atk/nsAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAccessibleWrap.cpp,v  <--  nsAccessibleWrap.cpp
new revision: 1.28; previous revision: 1.27
done
Checking in src/base/nsAccessibilityAtomList.h;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityAtomList.h,v  <--  nsAccessibilityAtomList.h
new revision: 1.33; previous revision: 1.32
done
Checking in src/base/nsAccessibilityService.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityService.cpp,v  <--  nsAccessibilityService.cpp
new revision: 1.164; previous revision: 1.163
done
Checking in src/xul/nsXULSelectAccessible.cpp;
/cvsroot/mozilla/accessible/src/xul/nsXULSelectAccessible.cpp,v  <--  nsXULSelectAccessible.cpp
new revision: 1.29; previous revision: 1.28
done

Comment 4

[Ginn Chen]

Sorry, I didn't review the code carefully enough.

In accessible/src/atk/nsAccessibleWrap.cpp,

+#ifndef ATK_ROLE_AUTOCOMPLETE
+        else if (accRole == nsIAccessible::ROLE_AUTOCOMPLETE) {
+			accRole == ATK_ROLE_COMBOBOX;
+		}
+#endif
+#ifndef ATK_ROLE_CAPTION
+        else if (accRole == nsIAccessible::ROLE_CAPTION) {
+			accRole == ATK_ROLE_LABEL;
+		}
+#endif

should be accRole = ATK_ROLE_

Please fix it.

Comment 5

[Aaron Leventhal]

Attachment: Change to ATK_ROLE_*

Ginn, does the code above that which deals with nsIAccessible::ROLE_MENUPOPUP etc. need to be changed?

Comment 6

[Ginn Chen]

Aaron, sorry for confusing.
I didn't mean to change nsIAccessible::ROLE_* to ATK_ROLE_*
I mean 
accRole == ATK_ROLE_COMBO_BOX; should be accRole = ATK_ROLE_COMBO_BOX;
accRole == ATK_ROLE_LABEL; should be accRole = ATK_ROLE_LABEL;
There is an extra "=".

Comment 7

[Aaron Leventhal]

Attachment: Correct patch

That's fine Ginn :) Obviously I wasn't thinking at all.

Comment 8

[[e-mail]]

Comment on attachment 218166 [details] [diff] [review]
Correct patch

That makes three ;-)

Comment 9

[Aaron Leventhal]

*** Bug 331142 has been marked as a duplicate of this bug. ***

Comment 10

[Ginn Chen]

Checking in public/nsIAccessible.idl;
/cvsroot/mozilla/accessible/public/nsIAccessible.idl,v  <--  nsIAccessible.idl
new revision: 1.41.4.1; previous revision: 1.41
done
Checking in src/atk/nsAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAccessibleWrap.cpp,v  <--  nsAccessibleWrap.cpp
new revision: 1.25.4.2; previous revision: 1.25.4.1
done
Checking in src/base/nsAccessibilityAtomList.h;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityAtomList.h,v  <--  nsAccessibilityAtomList.h
new revision: 1.31.2.2; previous revision: 1.31.2.1
done
Checking in src/base/nsAccessibilityService.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityService.cpp,v  <--  nsAccessibilityService.cpp
new revision: 1.151.2.9; previous revision: 1.151.2.8
done
Checking in src/xul/nsXULSelectAccessible.cpp;
/cvsroot/mozilla/accessible/src/xul/nsXULSelectAccessible.cpp,v  <--  nsXULSelectAccessible.cpp
new revision: 1.27.2.1; previous revision: 1.27
done