325644 - window.blur() fails on popup window in gtkmozembed

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Ernst Sjostrand]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; sv-SE; rv:1.8) Gecko/20060130 Ubuntu/1.5.dfsg-4ubuntu6 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; sv-SE; rv:1.8) Gecko/20060130 Ubuntu/1.5.dfsg-4ubuntu6 Firefox/1.5

window.blur() throws an exception in gtkmozembed which is not caught and kills the script, breaking webpages.
is it implemented?

the worst problem is on pages like this:
window.blur()
document.myForm.submit();

submit is never run. maybe just implement blur as a dummy?

uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowInternal.blur]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: http://helgon.net/guestbook/QuickMessage.asp?UserID=589312&UserName=BlaBlaBla&GuestBookID=17669269 :: SendGuestbook :: line 29"  data: no]

Reproducible: Always

Steps to Reproduce:
javascript:window.blur() in epiphany for example

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Bug 149307 suggests that gtkmozembed's EmbedWindow class needs to implement nsIEmbeddingSiteWindow2, whose only method is ::Blur.

Comment 2

[Benjamin Smedberg]

Attachment: Don't throw on unimplemented blur(), rev. 1

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 210518 [details] [diff] [review]
Don't throw on unimplemented blur(), rev. 1

- In nsGlobalWindow::Blur():

   nsresult rv = NS_ERROR_FAILURE;
 
   nsCOMPtr<nsIDocShellTreeOwner> treeOwner;
   GetTreeOwner(getter_AddRefs(treeOwner));
   nsCOMPtr<nsIEmbeddingSiteWindow2> siteWindow(do_GetInterface(treeOwner));
   if (siteWindow)
     rv = siteWindow->Blur();
 
   if (NS_SUCCEEDED(rv))
     mDocShell->SetHasFocus(PR_FALSE);
 
-  return rv;
+  // If embedding apps don't implement nsIEmbeddingSiteWindow2, we
+  // shouldn't throw to web content.
+  return NS_OK;

I'd recommend simply just changing what rv is initialized to instead, that way if the blur() function *does* throw an exception it'd make it out to JS rather than getting lost.

r=jst with that change.

Comment 4

[Benjamin Smedberg]

Fixed on trunk. If somebody wants to make gtkmozembed implement nsIEmbeddingSiteWindow2 please file a separate bug.