Closed Bug 325733 Opened 14 years ago Closed 14 years ago

Unclosed XML tags no longer trigger an error message

Categories

(Core :: XML, defect, major)

PowerPC
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: peterv)

References

()

Details

(Keywords: regression, testcase)

Attachments

(2 files, 1 obsolete file)

Steps to reproduce:
1. Load data:text/xml,<foo>.

Expected: XML parsing error.

Result: Shows a tree with a <foo> element.

Mac, trunk.  Regressed between 2006-01-26 and 2006-01-30.
Keywords: testcase
Attached file testcase
Attached patch v1 (obsolete) — Splinter Review
This fixes the bug. I need to check that it's the right thing to do.
Assignee: xml → peterv
Status: NEW → ASSIGNED
Blocks: 323299
Attached patch v1.1Splinter Review
This also fixes bug 326741.
Attachment #210605 - Attachment is obsolete: true
Attachment #213745 - Flags: superreview?(bzbarsky)
Attachment #213745 - Flags: review?(bzbarsky)
Comment on attachment 213745 [details] [diff] [review]
v1.1

r+sr=bzbarsky.

It would be good to add some unit tests testing these various conditions if we can.  Doing chunk boundaries could be tough, but perhaps a multiplex input stream passed to DOMParser could do the trick?  Or something?
Attachment #213745 - Flags: superreview?(bzbarsky)
Attachment #213745 - Flags: superreview+
Attachment #213745 - Flags: review?(bzbarsky)
Attachment #213745 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.