325772 - editAction.xul/pref.css/options.png/check.gif/dot.gif are unused and should be removed

Status: RESOLVED FIXED

(Firefox :: General, defect, P2)

Description

[:Gavin Sharp [email: [e-mail]]]

http://lxr.mozilla.org/mozilla1.8/search?string=editAction.xul
http://lxr.mozilla.org/mozilla1.8/search?string=pref.css
http://lxr.mozilla.org/mozilla1.8/source/browser/themes/pinstripe/browser/pref/
http://lxr.mozilla.org/mozilla1.8/source/toolkit/themes/winstripe/mozapps/pref/
http://lxr.mozilla.org/mozilla1.8/source/toolkit/themes/pinstripe/mozapps/pref/

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Patch removes:
browser/themes/pinstripe/browser/pref
(wasn't removed after http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=jar.mn&branch=&root=/cvsroot&subdir=mozilla/browser/themes/pinstripe/browser&command=DIFF_FRAMESET&rev1=1.7&rev2=1.8 )

mozilla/toolkit/themes/winstripe/mozapps/pref
mozilla/toolkit/themes/pinstripe/mozapps/pref

editAction.[xul|js|dtd]
( http://lxr.mozilla.org/seamonkey/find?string=editAction
http://lxr.mozilla.org/seamonkey/search?string=editAction )

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Checked in, branch and trunk.

Comment 4

[Marek Stępień [:marcoos, inactive]]

It seems that on the 1.8 branch the editAction.dtd file was truncated, but not removed.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/locales/en-US/chrome/mozapps/downloads&command=DIFF_FRAMESET&file=editAction.dtd&rev1=1.2&rev2=1.2.18.1&root=/cvsroot

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I removed the file on the branch. Thanks for catching that Marek!