Esc should cancel incomplete edit, not commit it, when closing Bookmark Info panel

RESOLVED FIXED in Camino1.5

Status

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: alqahira, Assigned: froodian)

Tracking

({fixed1.8.1.1})

unspecified
Camino1.5
PowerPC
macOS
fixed1.8.1.1
Dependency tree / graph

Details

Attachments

(1 attachment)

1.39 KB, patch
moz
: review+
stuart.morgan+bugzilla
: superreview+
Details | Diff | Splinter Review
In the bookmark info panel, Esc currently commits an in-progress edit and closes the info panel.  Instead, Esc should cancel the in-progress (uncommitted) edit when it closes the panel.
This panel has accumulated a list of bugs; see also bug 319746 and the depends list of bug 325880.
Assignee: mikepinkerton → nobody
OS: Mac OS X 10.2 → Mac OS X 10.3
QA Contact: bookmarks
Summary: Esc should cancel incomplete edit, not commit it, when closing Info panel → Esc should cancel incomplete edit, not commit it, when closing Bookmark Info panel
(Assignee)

Updated

13 years ago
Depends on: 337570
(Assignee)

Updated

13 years ago
Assignee: nobody → stridey
(Assignee)

Comment 2

13 years ago
Posted patch PatchSplinter Review
Attachment #244548 - Flags: review?(mozilla)
Comment on attachment 244548 [details] [diff] [review]
Patch

r=me, code-wise
Attachment #244548 - Flags: review?(mozilla) → review+
(Assignee)

Updated

13 years ago
Attachment #244548 - Flags: superreview?(stuart.morgan)

Comment 4

13 years ago
Comment on attachment 244548 [details] [diff] [review]
Patch

>+  // update UI so changes don't get committed

s/update/revert/

sr=smorgan with that change
Attachment #244548 - Flags: superreview?(stuart.morgan) → superreview+
(Assignee)

Updated

13 years ago
Depends on: 360345
Status: NEW → ASSIGNED
(Assignee)

Comment 5

13 years ago
Checked in on trunk and 1.8branch
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.