325932 - Hide Completed Tasks button doesn't work in nightly Sunbird for tasks created with Sunbird.2

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Guy Kindler]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060204 Mozilla Sunbird/0.3a1+

I downloaded the latest nightly Sunbird, and I like it. But the "Hide completed tasks" button did not hide any of the completed tasks. I went over them and "uncompleted" each one and then "completed" them again, and voila, their all gone.

This happened also with imported calendar files: To try to keep my info safe, I imported my 0.2 calendar file to a new calendar using the nightly version. The completed tasks were still showing (they show as completed, but they are still shown). Again, unchecking and then checking "completed" makes them vanish as they are supposed to.

Reproducible: Didn't try

Steps to Reproduce:
I didn't try to repeat this. I was just trying to move to a newer shinier version of Sunbird, and I thought this bug might be of interest now that a new version is coming our and many people might face a similar problem.

Comment 1

[Joey Minta]

Can you attach a testcase ics file that contains only a single 0.2 completed task that fails to be hidden?  Thanks.

Comment 2

[Guy Kindler]

Attachment: testcase - completed event kakaka remains in view

added a testcase: a file made with sunbird 0.2 with a completed event that remains shown when viewd in nightly sunbird, even when "Hide Completed Tasks" is checked.

Comment 3

[Joey Minta]

Attachment: use isCompleted

The hint here is that the items appear checked but not hidden.  The task-list uses isCompleted to assign the checkmarks, but the providers used several mish-mash algorithms for determining what tasks were completed for filtering purposes.  This patch moves them to also use isCompleted.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 210795 [details] [diff] [review]
use isCompleted

r=mvl

Comment 5

[Joey Minta]

Patch checked in.

Comment 6

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060926 Calendar/0.3a2+