Closed Bug 325964 Opened 15 years ago Closed 15 years ago

MathML missing fonts dialogue contatins extra space character (Camino-only)

Categories

(Core :: MathML, defect)

PowerPC
macOS
defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: alqahira)

Details

(Keywords: fixed1.8.1, Whiteboard: [camino-1.0][camino-1.0.1][camino-1.0.2][camino-1.0.3][camino-1.0.4][camino-1.0.5][camino-1.0.6])

Attachments

(2 files)

The MathML missing fonts dialogue contains an extra space character at the beginning of the " For further information see:" line.

http://lxr.mozilla.org/mozilla/source/layout/mathml/base/src/mathfont.properties#43

This extra space only appears in Camino (branch and trunk), I assume because Fx uses XUL for that warning and I assume XUL collapses the space?
Simply removing the spurious space in the in-app copies of the mathfont.properties file appeared to fix the bug in Camino and not harm Fx, so I assume this will work fine.  It's untested in an actual build situation, however.

mento, if this gets a positive review, can you land it on the Camino 1.0 branch?  I'm sure it cannot land on 1.8.0.x because of l10n issues for Fx, but those dialogues aren't l10n-able in Camino, and we're the only place where it actually looks bad.
Attachment #210750 - Flags: review?
Comment on attachment 210750 [details] [diff] [review]
patch (untested as a "real" patch)

r+sr=rbs
Attachment #210750 - Flags: superreview?(rbs)
Attachment #210750 - Flags: review?(rbs)
Attachment #210750 - Flags: review?
Comment on attachment 210750 [details] [diff] [review]
patch (untested as a "real" patch)

Marking r+ for rbs per comment 3.  r=me_too anyway.
Attachment #210750 - Flags: superreview?(rbs)
Attachment #210750 - Flags: superreview+
Attachment #210750 - Flags: review?(rbs)
Attachment #210750 - Flags: review+
Comment on attachment 210750 [details] [diff] [review]
patch (untested as a "real" patch)

Checked in on trunk and CAMINO_1_0_BRANCH.

Requesting approval for 1.8.0.2 - this takes a space out of the English message and doesn't really affect l10n.  It would be nice to get it on the branch so we wouldn't need to handle this on a minibranch for Camino 1.0.1.
Attachment #210750 - Flags: branch-1.8.1?(rbs)
Attachment #210750 - Flags: approval1.8.0.2?
Assignee: rbs → alqahira
Whiteboard: [camino-1.0]
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #210750 - Flags: branch-1.8.1?(rbs) → branch-1.8.1+
Keywords: fixed1.8.1
Comment on attachment 210750 [details] [diff] [review]
patch (untested as a "real" patch)

polish fix not in scope for 1.8.0.x
Attachment #210750 - Flags: approval1.8.0.2? → approval1.8.0.2-
Whiteboard: [camino-1.0] → [camino-1.0][camino-1.0.1][camino-1.0.2]
Whiteboard: [camino-1.0][camino-1.0.1][camino-1.0.2] → [camino-1.0][camino-1.0.1][camino-1.0.2][camino-1.0.3]
Whiteboard: [camino-1.0][camino-1.0.1][camino-1.0.2][camino-1.0.3] → [camino-1.0][camino-1.0.1][camino-1.0.2][camino-1.0.3][camino-1.0.4]
Whiteboard: [camino-1.0][camino-1.0.1][camino-1.0.2][camino-1.0.3][camino-1.0.4] → [camino-1.0][camino-1.0.1][camino-1.0.2][camino-1.0.3][camino-1.0.4][camino-1.0.5]
Whiteboard: [camino-1.0][camino-1.0.1][camino-1.0.2][camino-1.0.3][camino-1.0.4][camino-1.0.5] → [camino-1.0][camino-1.0.1][camino-1.0.2][camino-1.0.3][camino-1.0.4][camino-1.0.5][camino-1.0.6]
You need to log in before you can comment on or make changes to this bug.