Closed Bug 326062 Opened 19 years ago Closed 19 years ago

not all controls support readonly bind

Categories

(Core Graveyard :: XForms, defect)

Product:
Core Graveyard
Component:
XForms
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: spsh, Assigned: surkov)

References

Details

(Keywords: fixed1.8.0.4, fixed1.8.1)

Attachments

(3 files, 2 obsolete files)

testcase
1.51 KB, application/xhtml+xml
Details
patch for upload
3.03 KB, patch
allan
: review+
doronr
: review+
Details | Diff | Splinter Review
fix
1.21 KB, patch
allan
: review+
doronr
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060202 Firefox/1.6a1 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060202 Firefox/1.6a1 Only standard text input and textarea supports readonly bind Checkbox, date picker and upload controls doesn't support this in render, but doesn't change readonly instance node. Reproducible: Always Steps to Reproduce: 1. Open testcase
Attached file testcase —
Checkbox problem is go away with fix of bug 323845, datepicker problem - bug 323829. The problem with upload controls is actual.
Attached patch patch for upload (obsolete) — — Splinter Review
The fix probably is out of xforms controls writing concepts but it is simple and nice.
Attachment #210972 - Flags: review?(allan)
Comment on attachment 210972 [details] [diff] [review] patch for upload no go, the user needs to be able to see the selected file (if any)
Attachment #210972 - Flags: review?(allan) → review-
Attached patch patch (obsolete) — — Splinter Review
with allan comment
Attachment #210993 - Flags: review?(allan)
Attachment #210972 - Attachment is obsolete: true
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
Attached patch patch for upload — — Splinter Review
disabled="disabled" and readonly="readonly"
Attachment #210993 - Attachment is obsolete: true
Attachment #210995 - Flags: review?(allan)
Attachment #210993 - Flags: review?(allan)
Comment on attachment 210995 [details] [diff] [review] patch for upload r=me
Attachment #210995 - Attachment description: patch → patch for upload
Attachment #210995 - Flags: review?(allan) → review+
Attachment #210995 - Flags: review?(doronr)
Attachment #210995 - Flags: review?(doronr) → review+
Status: NEW → ASSIGNED
Assignee: aaronr → surkov
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Problems with input[type="boolean"] and input[type="date"] has gone away in current build.
(In reply to comment #6) > Created an attachment (id=210995) [edit] Checked in on trunk.
(In reply to comment #9) > (In reply to comment #6) > > Created an attachment (id=210995) [edit] > > Checked in on trunk. Problem is that it is not working :( There are two problems. The patch is "suboptimal", and the upload control does not set correct states: http://lxr.mozilla.org/seamonkey/source/extensions/xforms/nsXFormsUploadElement.cpp This is related to bug 313313.
Attached patch fix — — Splinter Review
Attachment #211963 - Flags: review+
Attachment #211963 - Flags: review?(doronr)
Attachment #211963 - Flags: review?(doronr) → review+
(In reply to comment #11) > Created an attachment (id=211963) [edit] Checked into trunk.
Whiteboard: xf-to-branch
Blocks: 326556
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Blocks: 332853
Keywords: fixed1.8.0.3, fixed1.8.1
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: