326245 - Print commands do not cope with spaces in printer names

Status: RESOLVED FIXED

Description

[Ian Jackson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060127 Ubuntu/1.5.dfsg-4ubuntu5 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060127 Ubuntu/1.5.dfsg-4ubuntu5 Firefox/1.5

print.postscript.print_command and print.print_command's default values should be changed as follows, so that they work correctly if the printer name contains whitespace:

-pref("print.postscript.print_command", "lpr ${MOZ_PRINTER_NAME:+'-P'}${MOZ_PRINTER_NAME}");
+pref("print.postscript.print_command", "lpr ${MOZ_PRINTER_NAME:+-P\"$MOZ_PRINTER_NAME\"}");


Reproducible: Always

Steps to Reproduce:
On an Ubuntu system, use the gnome print manager to add several copies of the same network printer.  The subsequent copies will have spaces in their names.  Now try to print from Firefox to one of those printers.  (NB that I have patched Ubuntu's firefox with the change above).

Comment 1

[Philip Withnall (unavailable)]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060224 Firefox/1.6a1 ID:0000000000
Confirmed.

Comment 2

[Mike Hommey [back on Jan 9] [:glandium]]

This still applies to Firefox 2.0 and Trunk.

Comment 3

[Reed Loden [:reed] (use needinfo?)]

(In reply to comment #2)
> This still applies to Firefox 2.0 and Trunk.

Could you put Ian's patch in actual patch format and request review? Thanks.

Comment 4

[Mike Hommey [back on Jan 9] [:glandium]]

Created attachment 292212 [details] [diff] [review]
Patch

Formalize the fix proposed in the bug report as a patch.

Comment 5

[Mike Hommey [back on Jan 9] [:glandium]]

> Could you put Ian's patch in actual patch format and request review? Thanks.

I did it even before noticing your note ^^

Comment 6

[Reed Loden [:reed] (use needinfo?)]

Comment on attachment 292212 [details] [diff] [review]
Patch

Just in case timeless is busy, maybe cls can review this instead.

Comment 7

[Kenneth Herron]

Could you also change the solaris versions of these prefs at the end of the file?

Comment 8

[Reed Loden [:reed] (use needinfo?)]

(In reply to comment #7)
> Could you also change the solaris versions of these prefs at the end of the
> file?

Once Mike has a new patch, would you be willing to review it, kherron?

Comment 9

[Mike Hommey [back on Jan 9] [:glandium]]

Created attachment 292217 [details] [diff] [review]
Patch also fixing Solaris's print command

Comment 10

[Reed Loden [:reed] (use needinfo?)]

Comment on attachment 292217 [details] [diff] [review]
Patch also fixing Solaris's print command

kherron, can you review this?

Comment 11

[Reed Loden [:reed] (use needinfo?)]

Comment on attachment 292217 [details] [diff] [review]
Patch also fixing Solaris's print command

Fixes print commands to cope with spaces in printer names.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 292217 [details] [diff] [review]
Patch also fixing Solaris's print command

a=beltzner for 1.9

Comment 13

[Reed Loden [:reed] (use needinfo?)]

Thanks for the patch!

Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.714; previous revision: 3.713
done