326258 - [mlk] Memory Leak with Forecastfox 0.8.5 extension

Status: RESOLVED INCOMPLETE

(Firefox :: General, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060207 Firefox/1.6a1

1. New Profile, Homepage about:blank
2. Install Forecastfox v0.8.5 from https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=398
3. Restart firefox with logging
4. Observe that the Forecastfox Options dialog is being displayed. Enter a location to get weather for (eg: 60601).
5. Click OK. (Note: Forecast's weather status icons will appear in the bottom right of the browser)
6. Close Firefox.

Analysis of nspr.log with leal-gauge.pl gives:
Leaked 2 out of 6 DOM Windows
Leaked 2 out of 30 documents
Leaked 0 out of 3 docshells

(Same for all subsequent starts of firefox with about:blank, close firefox, analyse log)

If my memory serves me correctly, the version before this release did not used to leak.

Comment 1

[Richard Klein]

Could someone test out our alpha of Forecastfox 0.9 and see if it is still leaking?  http://thekleins.freeservers.com/misc/forecastfox-0.9.xpi

Comment 2

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.2) Gecko/20060331 Firefox/1.5.0.2

1. New profile, start firefox
2. Install http://thekleins.freeservers.com/misc/forecastfox-0.9.xpi
3. Close firefox
4. Restart firefox with logging
5. Enter '65656' for area code and OK
6. Close firefox

Analysis of nspr.log with leak-gauge.pl gives

C:\Documents and Settings\Ste\Desktop\firefox-1.5.0.2.en-US.win32\firefox>perl l
eak-gauge.pl nspr.log
Leaked inner window 18da750 (outer 18cf020) at address 18da750.
 ... with URI "about:blank".
Leaked outer window 18cf020 at address 18cf020.
Leaked document at address 2105ca0.
 ... with URI "chrome://browser/content/browser.xul".
Leaked document at address 21c1730.
 ... with URI "file:///C:/Documents%20and%20Settings/Ste/Application%20Data/Mozi
lla/Firefox/Profiles/e3mbceuz.1502test/forecastfox/currentcache-default.xml".
Summary:
Leaked 2 out of 7 DOM Windows
Leaked 2 out of 30 documents
Leaked 0 out of 3 docshells

Subsequent close and restarts of firefox gives the same (ie: without entering the area code to get weather for).

So yes, it seems this reported leakage is still present in the 0.9 build.

Comment 3

[Jon Stritar]

This is fixed with the new version, Forecastfox 0.9.2.

http://releases.mozilla.org/pub/mozilla.org/extensions/forecastfox/forecastfox-0.9.2-fx+fl+mz+ns+zm.xpi

Comment 4

[Richard Klein]

Can anyone verify and close this bug?

Comment 5

[Worcester12345]

(In reply to comment #4)
> Can anyone verify and close this bug?
> 

Not sure on that, but yesterday's Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060615 Firefox/1.5.0.4 ID:2006061506 build with the new version of Forecastfox sure starts up quicker if nothing else.

Comment 6

[VanillaMozilla]

There is a report that 0.9.3 still leaks.
http://forums.mozillazine.org/viewtopic.php?p=2438921#2438921

Comment 7

[Richard Klein]

That is a report of high memory usage, not a memory leak.

Comment 8

[Worcester12345]

(In reply to comment #7)
> That is a report of high memory usage, not a memory leak.

I attempted to get that field added as a key word, but it was marked WONTFIX.

Bugzilla Bug 309374 Should add "memoryuse" keyword to bugzilla.

Comment 9

[Keith Ammann]

I'm using version 0.9.3.1. I have been having problems with autocomplete, scripting and other features for nearly two months; it was only today, when I tried disabling ForecastFox, that I traced the problem to the add-on. I've also experienced high memory usage and behavior that seems awfully leak-like. My bug report is at https://bugzilla.mozilla.org/show_bug.cgi?id=365919; nobody ever touched the damn thing.

Comment 10

[Wayne Mery (:wsmwk)]

stevee, VanillaMozilla, still see this?

Comment 11

[VanillaMozilla]

Yes, but I'm not following it.  Maybe someone should either check it out with recent versions to see if there really is (still) a leak, or else close the bug as incomplete.

Comment 12

[VanillaMozilla]

This just has to be too old.  Report is 5 years old, and OS no longer unsupported.

Comment 13

[Jesse Ruderman]

VanillaMozilla, age is never a valid reason to close a bug report, and "OS no longer supported" is only relevant for OS-specific bugs.

Comment 14

[Nicholas Nethercote [inactive]]

(In reply to Jesse Ruderman from comment #13)
> VanillaMozilla, age is never a valid reason to close a bug report, and "OS
> no longer supported" is only relevant for OS-specific bugs.

True, but ForecastFox is up to version 2.0.19 now, so I don't think keeping this bug open is useful.  Someone can reopen if the problem still exists in the recent version.

Comment 15

[VanillaMozilla]

Plus, there are credible reports here:  http://forums.mozillazine.org/viewtopic.php?t=523850 and here:  http://forums.mozillazine.org/viewtopic.php?p=2667408#p2667408 that indicate that it was fixed 5 years ago.  In addition, no recent complaints have been noted here:  http://kb.mozillazine.org/Problematic_extensions .