Closed
Bug 326358
Opened 20 years ago
Closed 20 years ago
checking for null mStringBundle is not needed...
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: KaiE)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.55 KB,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp line ~196
service->CreateBundle(SECURITY_STRING_BUNDLE_URL, getter_AddRefs(mStringBundle));
i do not think we should test for failure after this call because
(a) mStringBundle is checked before using
(b) it is only used for tooltips
(c) returning early causes the init not to complete.
I care about this because I reuse this file in my native ssl impl and I do not have the pip jar file for the properties.
|
Reporter | |
Comment 1•20 years ago
|
||
Attachment #211102 -
Flags: review?
|
Assignee | |
Updated•20 years ago
|
Attachment #211102 -
Flags: review? → review+
|
|
Reporter | |
Comment 2•20 years ago
|
||
Comment on attachment 211102 [details] [diff] [review]
Patch as described.
needed for wince/minimo. low risk.
Attachment #211102 -
Flags: branch-1.8.1?
|
|
Reporter | |
Updated•20 years ago
|
Attachment #211102 -
Flags: branch-1.8.1?
|
|
Reporter | |
Comment 3•20 years ago
|
||
Checking in manager/boot/src/nsSecureBrowserUIImpl.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v <-- nsSecureBrowserUIImpl.cpp
new revision: 1.48.2.5; previous revision: 1.48.2.4
Checking in manager/boot/src/nsSecureBrowserUIImpl.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v <-- nsSecureBrowserUIImpl.cpp
new revision: 1.55; previous revision: 1.54
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•20 years ago
|
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•