Closed Bug 326403 Opened 18 years ago Closed 18 years ago

NSS builtin certificate module manufacturer is Netscape

Categories

(NSS :: Libraries, defect, P2)

x86
All
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.11.1

People

(Reporter: wolfiR, Assigned: wtc)

Details

Attachments

(1 file, 1 obsolete file)

Just as I stumbled over this:

NSS builtin certificate module manufacturer is "Netscape Communications Corp.".
Maybe that should be changed nowadays to something like "Mozilla Foundation"?

security/nss/lib/ckfw/builtins/constants.c line 65
Yes, I think so.
Status: NEW → ASSIGNED
Yes it should. It looks like we should change the .rc files for all our libraries as well.

It looks like we also have Netscape as the company for softoken.

bob
Attached patch Proposed patch (obsolete) — Splinter Review
1. Change the manufacturerID of all of our PKCS #11
modules to "Mozilla Foundation".

Note that PSM overrides the softoken's manufacturerID
with a PK11_ConfigurePKCS11 call.

2. In the *.rc files, change the CompanyName to
"Mozilla Foundation" and remove the optional LegalCopyright.
Attachment #213481 - Flags: superreview?(julien.pierre.bugs)
Attachment #213481 - Flags: review?(rrelyea)
I missed lib/ckfw/dbm in the previous patch.
Attachment #213481 - Attachment is obsolete: true
Attachment #213483 - Flags: superreview?(julien.pierre.bugs)
Attachment #213483 - Flags: review?(rrelyea)
Attachment #213481 - Flags: superreview?(julien.pierre.bugs)
Attachment #213481 - Flags: review?(rrelyea)
Attachment #213483 - Flags: superreview?(julien.pierre.bugs) → superreview+
Comment on attachment 213483 [details] [diff] [review]
Proposed patch v2

r=relyea
Attachment #213483 - Flags: review?(rrelyea) → review+
I checked in the patch on the NSS trunk (NSS 3.12).  I
consider this bug a cosmetic problem, so I don't plan
to check in the fix on the Mozilla trunk or branches
until we upgrade Mozilla to NSS 3.12.

Here is the Microsoft documentation that says the
LegalCopyright field of the VERSIONINFO resource is
optional:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/tools/tools/versioninfo_resource.asp

  Platform SDK: SDK Tools
  VERSIONINFO Resource
  ...
  LegalCopyright   Copyright notices that apply to the file.
                   This should include the full text of all
                   notices, legal symbols, copyright dates,
                   and so on. This string is optional.
Severity: normal → trivial
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12
I figured Gerv and Frank might want to look at this.
Seems fine to me. I might have retained LegalCopyright (as e.g. "Mozilla Foundation and contributors") but as it's optional, I'm not worried.

Gerv
Checked in on NSS 3.11 branch.
ckfw/builtins/constants.c; new revision: 1.10.28.1; previous revision: 1.10
ckfw/builtins/nssckbi.rc;  new revision: 1.1.34.1; previous revision: 1.1
ckfw/capi/nsscapi.rc;      new revision: 1.1.2.1; previous revision: 1.1
ckfw/dbm/instance.c;       new revision: 1.2.28.2; previous revision: 1.2.28.1
freebl/freebl.rc;          new revision: 1.1.2.1; previous revision: 1.1
nss/nss.rc;                new revision: 1.2.28.1; previous revision: 1.2
smime/smime.rc;            new revision: 1.2.28.1; previous revision: 1.2
softoken/pkcs11.c;         new revision: 1.112.2.7; previous revision: 1.112.2.6
softoken/softokn.rc;       new revision: 1.9.30.1; previous revision: 1.9
ssl/ssl.rc;                new revision: 1.2.28.1; previous revision: 1.2
Priority: -- → P2
Target Milestone: 3.12 → 3.11.1
Version: unspecified → 3.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: