326523 - Reject blatantly invalid CTCP PING responses

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Rob Marshall [tH]]

In either a mis-understanding of the spec or an attempt to make itself look better, NoNameScript for mIRC sends back its own timestamp in PING responses instead of the one we sent in the request. As a result of ChatZilla using a different timestamp format, this results in meaningless ping times like "13174 days, 15 hours, 54 minutes, 26.77 seconds".

I'm going to attach a patch that displays an error if the timestamp returned is obviously wrong. Other possible fixes would be lightly encrypting the timestamp to make extra sure it isn't messed with, or only accepting responses if we've sent a ping request with the same timestamp.

Comment 1

[Rob Marshall [tH]]

Attachment: patch

Comment 2

[Samuel Sieb]

Comment on attachment 211249 [details] [diff] [review]
patch

Checking for a length of 10 is too specific.  We need a better check.

Comment 3

[James Ross]

Length != 13 is surely what we're after?

Comment 4

[Rob Marshall [tH]]

Attachment: length != 13

You're right. It's a long time since/until timestamps are a different length.

Comment 5

[:Gijs (he/him)]

Checked in --> FIXED.

Comment 6

[:Gijs (he/him)]

Nickserv's ping replies on moznet now show "invalid ping reply" too. I seem to remember that when we discussed this, all it took to fix was an extra stringTrim around the ctcp reply? Reopening to get that bit fixed.

Comment 7

[Rob Marshall [tH]]

When I send a ping targetted at a channel with a services bot in it, its response is even more broken ("PING PING 1142784964671 "). Should I make ChatZilla accept that as well?

Comment 8

[Rob Marshall [tH]]

Attachment: trim spaces

Comment 9

[James Ross]

Checked in --> FIXED (again).