326581 - Make show_activity.cgi adopt the template format/ctype mechanism

Status: UNCONFIRMED

(Bugzilla :: User Interface, enhancement)

Description

[Rémi Zara]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; fr) AppleWebKit/417.9 (KHTML, like Gecko) Safari/417.8
Build Identifier: 

This could help to for instance for AJAXifying the display of the bug activity

Reproducible: Always

Steps to Reproduce:

Comment 1

[Rémi Zara]

Attachment: adopt format/ctype mechanism

This patch also contains the removal of globals.pl from the cgi, which is a little out of scope. I could make a smaller patch if needed.

Comment 2

[Rémi Zara]

Attachment: patch v2, without removing globals.pl

When the guide says "just one change per patch", you really should make just one change per patch.
The removing of globals.pl from my previous patch was bogus... Sorry for the noise.

Comment 3

[Frédéric Buclin]

What is the interest of this change? Bugzilla offers no other format for the bug activity.

Comment 4

[Rémi Zara]

It could be used to provide a js version (or an xml version) of the activity so that it can be AJAX'ed in the show_bug page

Comment 5

[Frédéric Buclin]

Shouldn't we wait to really have such a JS or XML template before implementing this code change? Alone, it doesn't make sense (i.e. isn't useful).

Comment 6

[Rémi Zara]

Attachment: javascript template for bug activity

This is a javascript template for the bug activity.
It does not define a variable, and is designed to be eval'ed into one

It would be easy to make the template define a variable instead, but then you have to choose a name arbitrarily...

Comment 7

[Rémi Zara]

Attachment: proof of concept javascript to display the bug activity inline

This javascript is a proof of concept (tested with Safari and FireFox) which gets the bug activity and displays it inline in show_bug.cgi. It should be included in bug/edit.html.tmpl.

Best used with some CSS:

.activity {
	background-color: #efefef;
	border: 1px solid #bfbfbf;
	margin: 0.1em;
	width: 30em;
}

.activity p {
	margin: 0;
	padding: 0.25em;
	font-style: italic;
}

.activity_who {
	float: left;
}

.activity_when {
	float: right;
}

.activity ul {
	margin: 1em 0.25em 0.25em 0.25em;
	padding: 0;
}

.activity li {
	display: table-row;
}

.activity .activity_change_field, .activity ins, .activity del {
	display: table-cell;
	padding: 0.2em;
}

Comment 8

[Frédéric Buclin]

Comment on attachment 211629 [details] [diff] [review]
patch v2, without removing globals.pl

Cancelling request for review till my question in bug 327528 comment 5 is answered.

Comment 9

[Frédéric Buclin]

see also bug 112646

Comment 10

[Frédéric Buclin]

This bug is retargetted to Bugzilla 3.2 for one of the following reasons:

- it has no assignee (except the default one)
- we don't expect someone to fix it in the next two weeks (i.e. before we freeze the trunk to prepare Bugzilla 3.0 RC1)
- it's not a blocker

If you are working on this bug and you think you will be able to submit a patch in the next two weeks, retarget this bug to 3.0.

If this bug is something you would like to see implemented in 3.0 but you are not a developer or you don't think you will be able to fix this bug yourself in the next two weeks, please *do not* retarget this bug.

If you think this bug should absolutely be fixed before we release 3.0, either ask on IRC or use the "blocking3.0 flag".

Comment 11

[Max Kanat-Alexander]

Bugzilla 3.2 is now frozen. Only enhancements blocking 3.2 or specifically approved for 3.2 may be checked in to the 3.2 branch. If you would like to nominate your enhancement for Bugzilla 3.2, set "blocking3.2" tp "?", and either the target milestone will be changed back, or the blocking3.2 flag will be granted, if we will accept this enhancement for Bugzilla 3.2.

Comment 12

[Frédéric Buclin]

We are going to branch for Bugzilla 4.4 next week and this bug is either too invasive to be accepted for 4.4 at this point or shows no recent activity. The target milestone is reset and will be set again *only* when a patch is attached and approved.

I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else.