326672 - When loading an image, the unloaded part of it is black

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Martijn Wargers (dead)]

See url image.
When loading that image, the unloaded part of it is black in Cairo builds, in regular builds this is transparent (and it should be transparent).

Comment 1

[hiro]

Seem bug for all Jpg,gif image in 20060227 1.6a1 nightly

Comment 2

[hiro]

Seem bug for all Jpg,gif image in 20060227 1.6a1 nightly

Comment 3

[Michael Lelli]

The bug is also in the 2006031004 nightly build as well.

It also seems that some images appear as gray/black blocks in the tab favicon area.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060310 Firefox/1.6a1 - Build ID: 2006031004

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: use the mDecoded rectangle in nsThebesImage::Draw

This uses the mDecoded region to clip when drawing in nsThebesImage::Draw.  This doesn't handle the DrawTile case, because that's much harder (the clipped region becomes much more complex).

Comment 5

[Peter van der Woude [:Peter6]]

this patch caused a regression of partly displaying images / favicons, or not displaying them at all ,both on webpages as in browser/addons manager / places / bookmarks,

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yes, the scaled case is bug 336236; not sure why this is failing, but I'm on it.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

should be fixed