326823 - keyboard shortcut opens bookmark in new tab

Status: VERIFIED WONTFIX

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Rahul Abrol]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060210 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060210 Camino/1.0+

assigning a keyboard shortcut to a bookmark in the bookmarks menu (via system preferences, requires OS X.3 or greater) and then using that shortcut to trigger the bookmark opens it in a new tab.  even a simple javascript bookmarklet like:

javascript:alert("camino");

forces open a new tab before the alert displays.  all other triggers (selecting bookmark manually from the menu, bookmarks toolbar, or by keyword) work normally.

Reproducible: Always

Steps to Reproduce:
1. assign a keyboard shortcut to a bookmark via sys. prefs.
2. restart camino
3. use the shortcut

Actual Results:  
new tab is loaded, then the event fires.

Expected Results:  
the results should be the same whether the bookmark is triggered by mouse or by keyboard shortcut.

problem first noticed in 1.0rc1, though it probably existed before that.

i thought camino might be applying the "open links from other applications" setting, but trying all three possibilites yielded the same thing: new tab, then bookmark action.

Comment 1

[Rahul Abrol]

resolving bug 301670 might help here.

Comment 2

[Chris Lawson (gone)]

When you say "first noticed in rc1", did this occur in 1.0b1 or 1.0b2?

cl

Comment 3

[Chris Lawson (gone)]

Confirming with 1.0rc1, asking for 1.0 blocking.

This is probably more fallout from bug 295858 and its related regressions.

cl

Comment 4

[Rahul Abrol]

(In reply to comment #2)
> When you say "first noticed in rc1", did this occur in 1.0b1 or 1.0b2?
> 
> cl
> 

no idea.  i first tried it on 1.0rc1.

Comment 5

[Stuart Morgan]

This isn't all all surprising and I very much doubt it's a regression--holding down the command key means "open in new tab/window". Holding down the command key while clicking a bookmark in the bar opens in a new tab/window, holding down the command key while selecting a bookmark from the menu opens a new tab/window, so triggering it with a command-key shortcut is going to open in a new tab/window.

Fixing this would probably mean breaking the ability to open bookmarks from the menu in a new tab/window, which is arguably a lot more likely than someone assigning keyboard shortcuts to bookmarks.

Comment 6

[Wevah (Nate Weaver)]

We could probably do a check to make sure the current event is a mouse event, but maybe that'd be inconsistent behavior.

Comment 7

[Wevah (Nate Weaver)]

Although, come to think of it, I don't remember if mouse events are fired for menu tracking, or not, either.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #5)
> Fixing this would probably mean breaking the ability to open bookmarks from the
> menu in a new tab/window, which is arguably a lot more likely than someone
> assigning keyboard shortcuts to bookmarks.

For this reason I suggest WONTFIX; the cmd-select shortcut is actually documented in the "Misc Shortcuts" section of the new Keyboard Shortcuts document.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This happens at least as far back as 0.8.4, so, as Stuart notes, it's not a recent regression.  It's in no way serious enough to consider for blocking 1.0 at this stage, either, so minusing.

Comment 10

[Rahul Abrol]

the problem is that, combined with (part of) bug 301670, javascript bookmarklets won't work with any keyboard shortcut.  command+(any key) forces open a new tab/window and thus targets the wrong object, whereas non-command key modifiers get swallowed by the browser/content area.

i think the latter problem is more severe, so WONTFIXING this bug is fine if the other one gets resolved.

Comment 11

[Stuart Morgan]

(In reply to comment #6)
> We could probably do a check to make sure the current event is a mouse event,
> but maybe that'd be inconsistent behavior.

Especially since even if you could do that you'd catch people activating the menu item through keyboard navigation.  There's no way to make everyone happy, and the current behavior is at least fully consistent.

Comment 12

[Mike Pinkerton (not reading bugmail)]

yeah im not sure what we can do that will get all cases...

Comment 13

[froodian (Ian Leue)]

IMO, this is WONTFIX.  If people really need a fast way to fire bookmarks, that's what keywords are for.

Comment 14

[Rahul Abrol]

marking as WONTFIX, since no one else did.