Closed Bug 326910 Opened 18 years ago Closed 18 years ago

[FIX]Defining a property with an empty <setter> leads to segfault

Categories

(Core :: XBL, defect, P3)

Product:
Core
Component:
XBL
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: TheSeer, Assigned: bzbarsky)

Details

(Keywords: fixed1.8.1, testcase)

Attachments

(3 files, 1 obsolete file)

XBL Defintion with empty setter
528 bytes, text/xml
Details
Testcase XUL - Using Testcase XBL directly
215 bytes, application/vnd.mozilla.xul+xml
Details
Fix
2.02 KB, patch
sicking
: review+
bryner
: superreview+
jst
: approval-branch-1.8.1+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060130 SeaMonkey/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060130 SeaMonkey/1.0

binding an element to an xbl that defines a property but has an empty <setter> method (<setter></setter>) causes crash

Reproducible: Always

Steps to Reproduce:
1. try to load attached testcase


Actual Results:  
segfault

Expected Results:  
either page loaded as normal, an exception of some kind for invalid XBL property defintion when code tries to set a value to the property inquestion

    
    

    
  


  

    
    

    
  


  

        Attachment #211599 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix
        — 
          — Splinter Review
      

    


  
Assignee: general → bzbarsky
Status: UNCONFIRMED → ASSIGNED

        Attachment #211610 -
        Flags: superreview?(bryner)

        Attachment #211610 -
        Flags: review?(bugmail)

        Attachment #211610 -
        Flags: approval-branch-1.8.1?(jst)

    
  
Priority: -- → P3
Summary: Defining a property with an empty <setter> leads to segfault → [FIX]Defining a property with an empty <setter> leads to segfault
Target Milestone: --- → mozilla1.9alpha

        Attachment #211610 -
        Flags: superreview?(bryner) → superreview+
Keywords: testcase

    
    

    
  
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

        Attachment #211610 -
        Flags: approval-branch-1.8.1?(jst) → approval-branch-1.8.1+

    
    

    
  
Fixed on 1.8.1 branch.
Keywords: fixed1.8.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: