326942 - XPath namespace nodes should QI to nsIDOM3Node

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Alex Vincent [:WeirdAl]]

Any node that QI's to nsIDOMNode should in theory QI to nsIDOM3Node as well.  We don't currently do that for XPath namespace nodes.

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: QI to nsIDOM3Node

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 211645 [details] [diff] [review]
QI to nsIDOM3Node

r=me if jst says we really should always QI to nsIDOM3Node. Otherwise this is just a waste of code.

Comment 3

[Alex Vincent [:WeirdAl]]

Comment on attachment 211645 [details] [diff] [review]
QI to nsIDOM3Node

Seeking sr from jst, then.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 211645 [details] [diff] [review]
QI to nsIDOM3Node

Actually, come to think of it. We should #if 0 out this entire class. Until bug 94270 is fixed we will never use this code.

If you want to write a patch that does that i'll r it.

Comment 5

[Alex Vincent [:WeirdAl]]

Attachment: QI to nsIDOM3Node (#ifdef 0)

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 211716 [details] [diff] [review]
QI to nsIDOM3Node (#ifdef 0)

No, I mean that the entire class should be #if 0

Comment 7

[Alex Vincent [:WeirdAl]]

Oh, I guess I didn't read your comment 4 closely enough.  I'm perfectly content to let this bug lurk in the depths of DOM until such time as someone resuscitates bug 94270's patch.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Turns out this file isn't being currently built yet.

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

nsIDOM3Node doesn't exist anymore.