326964 - ###!!! ASSERTION: Invalid node type!: '(nodeType == nsIDOMNode::ELEMENT_NODE || nodeType == nsIDOMNode::TEXT_NODE || ... , file m:/mozilla/content/base/src/nsGenericElement.cpp, line 394

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Alex Vincent [:WeirdAl]]

I called on (DocumentType)->compareDocumentPosition(node), and hit this assertion.  Tracing the code onward, it's clear Mozilla does the right thing and returns the right value.  So for document type nodes, this assertion is bogus.

Testcase and patch coming up.

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: testcase

Comment 2

[Alex Vincent [:WeirdAl]]

Attachment: Console output for the assertions

Comment 3

[Alex Vincent [:WeirdAl]]

Attachment: fixed testcase

Sorry, the original test case had leftover debugging code in it and wouldn't return completely correct results.

Comment 4

[Alex Vincent [:WeirdAl]]

Reference attachment 211672 [details] for the testcase, and ignore the alert.  For x.compareDocumentPosition(y), x represents the row, and y represents the column.

Comment 5

[Alex Vincent [:WeirdAl]]

Attachment: patch

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

checked in to trunk:
Checking in content/base/src/nsGenericElement.cpp;
/cvsroot/mozilla/content/base/src/nsGenericElement.cpp,v  <--  nsGenericElement.cpp
new revision: 3.447; previous revision: 3.446
done