###!!! ASSERTION: Invalid node type!: '(nodeType == nsIDOMNode::ELEMENT_NODE || nodeType == nsIDOMNode::TEXT_NODE || ... , file m:/mozilla/content/base/src/nsGenericElement.cpp, line 394

RESOLVED FIXED

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: WeirdAl, Assigned: Christopher Aillon (sabbatical, not receiving bugmail))

Tracking

({assertion, testcase})

Trunk
assertion, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
I called on (DocumentType)->compareDocumentPosition(node), and hit this assertion.  Tracing the code onward, it's clear Mozilla does the right thing and returns the right value.  So for document type nodes, this assertion is bogus.

Testcase and patch coming up.
(Reporter)

Comment 1

12 years ago
Created attachment 211670 [details]
testcase
(Reporter)

Comment 2

12 years ago
Created attachment 211671 [details]
Console output for the assertions
(Reporter)

Comment 3

12 years ago
Created attachment 211672 [details]
fixed testcase

Sorry, the original test case had leftover debugging code in it and wouldn't return completely correct results.
Attachment #211670 - Attachment is obsolete: true
(Reporter)

Comment 4

12 years ago
Reference attachment 211672 [details] for the testcase, and ignore the alert.  For x.compareDocumentPosition(y), x represents the row, and y represents the column.
(Reporter)

Comment 5

12 years ago
Created attachment 211673 [details] [diff] [review]
patch
Attachment #211673 - Flags: superreview?(bzbarsky)
Attachment #211673 - Flags: review?(bzbarsky)
Attachment #211673 - Flags: superreview?(bzbarsky)
Attachment #211673 - Flags: superreview+
Attachment #211673 - Flags: review?(bzbarsky)
Attachment #211673 - Flags: review+
checked in to trunk:
Checking in content/base/src/nsGenericElement.cpp;
/cvsroot/mozilla/content/base/src/nsGenericElement.cpp,v  <--  nsGenericElement.cpp
new revision: 3.447; previous revision: 3.446
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: DOM: Core → DOM: Core & HTML
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.