327005 - password manager prefs not set

Status: RESOLVED INCOMPLETE

(Toolkit Graveyard :: XULRunner, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

XULrunner includes passwordmanager, but the prefs that enable it aren't set.

Those prefs are set to this in ff:
http://lxr.mozilla.org/seamonkey/source/browser/app/profile/firefox.js#362 :
362 pref("signon.rememberSignons",              true);
363 pref("signon.expireMasterPassword",         false);
364 pref("signon.SignonFileName", "signons.txt");

Even if you don't want to turn it on by default, IMHO these prefs should be included (with rememberSignons=true in that case), so embedders just have to flip one pref instead of adding any number of undocumented prefs.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

So what happens without these prefs? Do you get JS or some other kind of errors? Or you're just never offered the opportunity to remember passwords?

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

When the pref isn't set, you don't get password prefill in web forms, and no prompt to save the password data on submit.

Comment 3

[steve.swanson]

I'm now getting an ASSERT when I start up XULRunner

ASSERTION: Fallback for signon filename not present: '!signonFile.IsEmpty()', file d:/Mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp, line 1733

This didn't happen last week.

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #3)
> I'm now getting an ASSERT when I start up XULRunner
> 
> ASSERTION: Fallback for signon filename not present: '!signonFile.IsEmpty()',
> file
> d:/Mozilla/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,
> line 1733
> 
> This didn't happen last week.

I think that a problem's from the patch from bug 221634.

Comment 5

[Benjamin Smedberg]

I'm not going to track this. If somebody wants to fix this, they may reopen it and provide a patch.