Closed
Bug 327046
Opened 19 years ago
Closed 19 years ago
[BeOS] Changes in 326149 seem to have broken BeOS builds
Categories
(Core Graveyard :: GFX, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: doug, Assigned: sergei_d)
Details
Attachments
(3 files, 4 obsolete files)
User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060206 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060206 Firefox/1.6a1
BeOS build dies in mozilla/gfx/src/beos/nsDeviceContextSpecFactoryB.cpp
`NS_DEVICE_CONTEXT_SPEC_CID' undeclared (first use this function)
Reproducible: Always
Reporter | ||
Comment 1•19 years ago
|
||
Reporter | ||
Updated•19 years ago
|
Component: General → GFX
Product: Firefox → Core
Version: unspecified → Trunk
Comment 2•19 years ago
|
||
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 3•19 years ago
|
||
#include "nsWidgetsCID.h"
in nsDeviceContextSpecFactorB.cpp fixes this build problem but now creates problems in nsGfxFactoryBeOS.cpp
Reporter | ||
Comment 4•19 years ago
|
||
Assignee | ||
Comment 5•19 years ago
|
||
time to move also our printing things into widget?
Comment 6•19 years ago
|
||
does the printing code even work?
Reporter | ||
Comment 7•19 years ago
|
||
(In reply to comment #6)
> does the printing code even work?
>
sadly, no. lack of functional printing is one of the longest-standing holes in our implementation.
(In reply to comment #5)
> time to move also our printing things into widget?
>
seems like this is the general direction. maybe in moving the code, we can also gain inspiration to fix printing, too... ;)
Assignee | ||
Comment 8•19 years ago
|
||
No PrintSettings yet, so our list is shorter
Assignee | ||
Updated•19 years ago
|
Attachment #211846 -
Attachment description: list of files tp move → list of files to move
Assignee | ||
Comment 9•19 years ago
|
||
Doug, can you test it?
first, move files according to list;
second, apply the patch
Assignee | ||
Comment 10•19 years ago
|
||
Comment on attachment 211851 [details] [diff] [review]
patch
oops, patch is unsufficient. It does not reflect changes in widget.
looks like file should be moved first in cvs tree.
Attachment #211851 -
Attachment is obsolete: true
Assignee | ||
Comment 11•19 years ago
|
||
files moved:
cvs commit -m'[BeOS]Bug 327046. Moving printing to widget' nsDeviceContextSpecB.cpp nsDeviceContextSpecB.h nsDeviceContextSpecFactoryB.cpp nsDeviceContextSpecFactoryB.h nsPrintOptionsBeOS.cpp nsPrintOptionsBeOS.h
Enter passphrase for key '/boot/home/.ssh/id_dsa':
RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.cpp,v
done
Checking in nsDeviceContextSpecB.cpp;
/cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.cpp,v <-- nsDeviceContextSpecB.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.h,v
done
Checking in nsDeviceContextSpecB.h;
/cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.h,v <-- nsDeviceContextSpecB.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.cpp,v
done
Checking in nsDeviceContextSpecFactoryB.cpp;
/cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.cpp,v <-- nsDeviceContextSpecFactoryB.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.h,v
done
Checking in nsDeviceContextSpecFactoryB.h;
/cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.h,v <-- nsDeviceContextSpecFactoryB.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.cpp,v
done
Checking in nsPrintOptionsBeOS.cpp;
/cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.cpp,v <-- nsPrintOptionsBeOS.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.h,v
done
Checking in nsPrintOptionsBeOS.h;
/cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.h,v <-- nsPrintOptionsBeOS.h
initial revision: 1.1
done
Assignee | ||
Comment 13•19 years ago
|
||
removed files from gfx
cvs ci -m'[BeOS]Bug 327046. Moving printing to widget'
cvs commit: Examining .
Enter passphrase for key '/boot/home/.ssh/id_dsa':
Checking in Makefile.in;
/cvsroot/mozilla/gfx/src/beos/Makefile.in,v <-- Makefile.in
new revision: 1.29; previous revision: 1.28
done
Removing nsDeviceContextSpecB.cpp;
/cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecB.cpp,v <-- nsDeviceContextSpecB.cpp
new revision: delete; previous revision: 1.34
done
Removing nsDeviceContextSpecB.h;
/cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecB.h,v <-- nsDeviceContextSpecB.h
new revision: delete; previous revision: 1.18
done
Removing nsDeviceContextSpecFactoryB.cpp;
/cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecFactoryB.cpp,v <-- nsDeviceContextSpecFactoryB.cpp
new revision: delete; previous revision: 1.17
done
Removing nsDeviceContextSpecFactoryB.h;
/cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecFactoryB.h,v <-- nsDeviceContextSpecFactoryB.h
new revision: delete; previous revision: 1.9
done
Checking in nsGfxFactoryBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsGfxFactoryBeOS.cpp,v <-- nsGfxFactoryBeOS.cpp
new revision: 1.27; previous revision: 1.26
done
Removing nsPrintOptionsBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsPrintOptionsBeOS.cpp,v <-- nsPrintOptionsBeOS.cpp
new revision: delete; previous revision: 1.2
done
Removing nsPrintOptionsBeOS.h;
/cvsroot/mozilla/gfx/src/beos/nsPrintOptionsBeOS.h,v <-- nsPrintOptionsBeOS.h
new revision: delete; previous revision: 1.2
done
Assignee | ||
Comment 14•19 years ago
|
||
looks like did widget commit (to add new files) against already modified widget/src/beos and gfx/src/beos
So, patch is here rather to reflect changes than to apply:)
So, after checkout fo those folders, only configure is required, to create Makefile-s from Makefile.in-s
Reporter | ||
Comment 15•19 years ago
|
||
I think we're closer, fyysik, but not there yet. Building now fails in widget, not gfx. Attachment shows console output.
Reporter | ||
Updated•19 years ago
|
Attachment #211756 -
Attachment is obsolete: true
Reporter | ||
Updated•19 years ago
|
Attachment #211765 -
Attachment is obsolete: true
Comment 16•19 years ago
|
||
Comment on attachment 211853 [details] [diff] [review]
patch for both gfx and widget
mozilla/widget/src/beos/nsWidgetFactory.cpp
+ { "BeOS PrintSettings Service",
+ NS_PRINTSETTINGSSERVICE_CID,
+ "@mozilla.org/gfx/printsettings-service;1",
+ nsPrintOptionsBeOSConstructor },
this is indented wrongly
r=biesi, looks ok, but I didn't review it very closely.
Attachment #211853 -
Flags: review?(cbiesinger) → review+
Assignee | ||
Comment 17•19 years ago
|
||
Doug
1)I don't see terminal output, but patch text there.
2)try to just checkout bot folders from cvs tree(gfx/src/beos and widget/src/beos) and modify Makefile-s in both according Makefile.in respective files. Maybe there is need to wait a bit, until changes in main cvs server reach cvs-mirrors (you get files from mirrors with anonymous cvs-account)
Comment 18•19 years ago
|
||
> and modify Makefile-s in both according Makefile.in
Makefile should be automatically updated when Makefile.in changes.
Assignee | ||
Comment 19•19 years ago
|
||
Comment 18:
Without configure ?
Reporter | ||
Comment 20•19 years ago
|
||
Attachment #211854 -
Attachment is obsolete: true
Assignee | ||
Comment 21•19 years ago
|
||
cvs commit -m'[BeOS]Bug 327046. Moving printing to widget. Adding nsPrintdBeOS.h' cvs commit: Examining .
Enter passphrase for key '/boot/home/.ssh/id_dsa':
Checking in Makefile.in;
/cvsroot/mozilla/widget/src/beos/Makefile.in,v <-- Makefile.in
new revision: 1.52; previous revision: 1.51
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsPrintdBeOS.h,v
done
Checking in nsPrintdBeOS.h;
/cvsroot/mozilla/widget/src/beos/nsPrintdBeOS.h,v <-- nsPrintdBeOS.h
initial revision: 1.1
done
Checking in nsWidgetFactory.cpp;
/cvsroot/mozilla/widget/src/beos/nsWidgetFactory.cpp,v <-- nsWidgetFactory.cpp
new revision: 1.36; previous revision: 1.35
done
Assignee | ||
Comment 22•19 years ago
|
||
cvs ci -m'[BeOS]Bug 327046. Moving printing to widget. nsPrintdBeOS.h' cvs commit: Examining . Enter passphrase for key '/boot/home/.ssh/id_dsa': Removing nsPrintdBeOS.h;
/cvsroot/mozilla/gfx/src/beos/nsPrintdBeOS.h,v <-- nsPrintdBeOS.h
new revision: delete; previous revision: 1.7
done
Assignee | ||
Comment 23•19 years ago
|
||
Doug, move
nsPrintdBeOS.h
from gfx to widget and try again
Comment 24•19 years ago
|
||
(In reply to comment #19)
> Comment 18:
> Without configure ?
yes
Reporter | ||
Comment 25•19 years ago
|
||
(In reply to comment #23)
> Doug, move
> nsPrintdBeOS.h
> from gfx to widget and try again
>
to be safe, I deleted gfx/src/beos and widget/src/beos and did CVS updates to pull the latest. Debug version built clean and seems to run OK. New strange problem, though: icons in the download manager are corrupted.
Assignee | ||
Comment 26•19 years ago
|
||
Will close it when Doug reports success in building both gfx and widget for new full source checkout (not only those thwo dirs)
Assignee: nobody → sergei_d
Assignee | ||
Comment 27•19 years ago
|
||
closing
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•