Closed Bug 327046 Opened 19 years ago Closed 19 years ago

[BeOS] Changes in 326149 seem to have broken BeOS builds

Categories

(Core Graveyard :: GFX, defect)

x86
BeOS
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: doug, Assigned: sergei_d)

Details

Attachments

(3 files, 4 obsolete files)

User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060206 Firefox/1.6a1 Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060206 Firefox/1.6a1 BeOS build dies in mozilla/gfx/src/beos/nsDeviceContextSpecFactoryB.cpp `NS_DEVICE_CONTEXT_SPEC_CID' undeclared (first use this function) Reproducible: Always
Attached file console output of bustage (obsolete) —
Component: General → GFX
Product: Firefox → Core
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
#include "nsWidgetsCID.h" in nsDeviceContextSpecFactorB.cpp fixes this build problem but now creates problems in nsGfxFactoryBeOS.cpp
time to move also our printing things into widget?
does the printing code even work?
(In reply to comment #6) > does the printing code even work? > sadly, no. lack of functional printing is one of the longest-standing holes in our implementation. (In reply to comment #5) > time to move also our printing things into widget? > seems like this is the general direction. maybe in moving the code, we can also gain inspiration to fix printing, too... ;)
Attached file list of files to move
No PrintSettings yet, so our list is shorter
Attachment #211846 - Attachment description: list of files tp move → list of files to move
Attached patch patch (obsolete) — Splinter Review
Doug, can you test it? first, move files according to list; second, apply the patch
Comment on attachment 211851 [details] [diff] [review] patch oops, patch is unsufficient. It does not reflect changes in widget. looks like file should be moved first in cvs tree.
Attachment #211851 - Attachment is obsolete: true
files moved: cvs commit -m'[BeOS]Bug 327046. Moving printing to widget' nsDeviceContextSpecB.cpp nsDeviceContextSpecB.h nsDeviceContextSpecFactoryB.cpp nsDeviceContextSpecFactoryB.h nsPrintOptionsBeOS.cpp nsPrintOptionsBeOS.h Enter passphrase for key '/boot/home/.ssh/id_dsa': RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.cpp,v done Checking in nsDeviceContextSpecB.cpp; /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.cpp,v <-- nsDeviceContextSpecB.cpp initial revision: 1.1 done RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.h,v done Checking in nsDeviceContextSpecB.h; /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.h,v <-- nsDeviceContextSpecB.h initial revision: 1.1 done RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.cpp,v done Checking in nsDeviceContextSpecFactoryB.cpp; /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.cpp,v <-- nsDeviceContextSpecFactoryB.cpp initial revision: 1.1 done RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.h,v done Checking in nsDeviceContextSpecFactoryB.h; /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.h,v <-- nsDeviceContextSpecFactoryB.h initial revision: 1.1 done RCS file: /cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.cpp,v done Checking in nsPrintOptionsBeOS.cpp; /cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.cpp,v <-- nsPrintOptionsBeOS.cpp initial revision: 1.1 done RCS file: /cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.h,v done Checking in nsPrintOptionsBeOS.h; /cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.h,v <-- nsPrintOptionsBeOS.h initial revision: 1.1 done
second take.
Attachment #211853 - Flags: review?(cbiesinger)
removed files from gfx cvs ci -m'[BeOS]Bug 327046. Moving printing to widget' cvs commit: Examining . Enter passphrase for key '/boot/home/.ssh/id_dsa': Checking in Makefile.in; /cvsroot/mozilla/gfx/src/beos/Makefile.in,v <-- Makefile.in new revision: 1.29; previous revision: 1.28 done Removing nsDeviceContextSpecB.cpp; /cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecB.cpp,v <-- nsDeviceContextSpecB.cpp new revision: delete; previous revision: 1.34 done Removing nsDeviceContextSpecB.h; /cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecB.h,v <-- nsDeviceContextSpecB.h new revision: delete; previous revision: 1.18 done Removing nsDeviceContextSpecFactoryB.cpp; /cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecFactoryB.cpp,v <-- nsDeviceContextSpecFactoryB.cpp new revision: delete; previous revision: 1.17 done Removing nsDeviceContextSpecFactoryB.h; /cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecFactoryB.h,v <-- nsDeviceContextSpecFactoryB.h new revision: delete; previous revision: 1.9 done Checking in nsGfxFactoryBeOS.cpp; /cvsroot/mozilla/gfx/src/beos/nsGfxFactoryBeOS.cpp,v <-- nsGfxFactoryBeOS.cpp new revision: 1.27; previous revision: 1.26 done Removing nsPrintOptionsBeOS.cpp; /cvsroot/mozilla/gfx/src/beos/nsPrintOptionsBeOS.cpp,v <-- nsPrintOptionsBeOS.cpp new revision: delete; previous revision: 1.2 done Removing nsPrintOptionsBeOS.h; /cvsroot/mozilla/gfx/src/beos/nsPrintOptionsBeOS.h,v <-- nsPrintOptionsBeOS.h new revision: delete; previous revision: 1.2 done
looks like did widget commit (to add new files) against already modified widget/src/beos and gfx/src/beos So, patch is here rather to reflect changes than to apply:) So, after checkout fo those folders, only configure is required, to create Makefile-s from Makefile.in-s
I think we're closer, fyysik, but not there yet. Building now fails in widget, not gfx. Attachment shows console output.
Attachment #211756 - Attachment is obsolete: true
Attachment #211765 - Attachment is obsolete: true
Comment on attachment 211853 [details] [diff] [review] patch for both gfx and widget mozilla/widget/src/beos/nsWidgetFactory.cpp + { "BeOS PrintSettings Service", + NS_PRINTSETTINGSSERVICE_CID, + "@mozilla.org/gfx/printsettings-service;1", + nsPrintOptionsBeOSConstructor }, this is indented wrongly r=biesi, looks ok, but I didn't review it very closely.
Attachment #211853 - Flags: review?(cbiesinger) → review+
Doug 1)I don't see terminal output, but patch text there. 2)try to just checkout bot folders from cvs tree(gfx/src/beos and widget/src/beos) and modify Makefile-s in both according Makefile.in respective files. Maybe there is need to wait a bit, until changes in main cvs server reach cvs-mirrors (you get files from mirrors with anonymous cvs-account)
> and modify Makefile-s in both according Makefile.in Makefile should be automatically updated when Makefile.in changes.
Comment 18: Without configure ?
cvs commit -m'[BeOS]Bug 327046. Moving printing to widget. Adding nsPrintdBeOS.h' cvs commit: Examining . Enter passphrase for key '/boot/home/.ssh/id_dsa': Checking in Makefile.in; /cvsroot/mozilla/widget/src/beos/Makefile.in,v <-- Makefile.in new revision: 1.52; previous revision: 1.51 done RCS file: /cvsroot/mozilla/widget/src/beos/nsPrintdBeOS.h,v done Checking in nsPrintdBeOS.h; /cvsroot/mozilla/widget/src/beos/nsPrintdBeOS.h,v <-- nsPrintdBeOS.h initial revision: 1.1 done Checking in nsWidgetFactory.cpp; /cvsroot/mozilla/widget/src/beos/nsWidgetFactory.cpp,v <-- nsWidgetFactory.cpp new revision: 1.36; previous revision: 1.35 done
cvs ci -m'[BeOS]Bug 327046. Moving printing to widget. nsPrintdBeOS.h' cvs commit: Examining . Enter passphrase for key '/boot/home/.ssh/id_dsa': Removing nsPrintdBeOS.h; /cvsroot/mozilla/gfx/src/beos/nsPrintdBeOS.h,v <-- nsPrintdBeOS.h new revision: delete; previous revision: 1.7 done
Doug, move nsPrintdBeOS.h from gfx to widget and try again
(In reply to comment #19) > Comment 18: > Without configure ? yes
(In reply to comment #23) > Doug, move > nsPrintdBeOS.h > from gfx to widget and try again > to be safe, I deleted gfx/src/beos and widget/src/beos and did CVS updates to pull the latest. Debug version built clean and seems to run OK. New strange problem, though: icons in the download manager are corrupted.
Will close it when Doug reports success in building both gfx and widget for new full source checkout (not only those thwo dirs)
Assignee: nobody → sergei_d
closing
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: