327046 - [BeOS] Changes in 326149 seem to have broken BeOS builds

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Doug Shelton]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060206 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060206 Firefox/1.6a1

BeOS build dies in mozilla/gfx/src/beos/nsDeviceContextSpecFactoryB.cpp
`NS_DEVICE_CONTEXT_SPEC_CID' undeclared (first use this function)

Reproducible: Always

Comment 1

[Doug Shelton]

Attachment: console output of bustage

Comment 2

[Benjamin Smedberg]

http://lxr.mozilla.org/mozilla/source/widget/public/nsWidgetsCID.h#151

Comment 3

[Doug Shelton]

#include "nsWidgetsCID.h" 
in nsDeviceContextSpecFactorB.cpp fixes this build problem but now creates problems in nsGfxFactoryBeOS.cpp 

Comment 4

[Doug Shelton]

Attachment: console output of nsGfxFactoryBeOS bustage

Comment 5

[Sergei Dolgov]

time to move also our printing things into widget?

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

does the printing code even work?

Comment 7

[Doug Shelton]

(In reply to comment #6)
> does the printing code even work?
> 
sadly, no.  lack of functional printing is one of the longest-standing holes in our implementation.

(In reply to comment #5)
> time to move also our printing things into widget?
> 
seems like this is the general direction.  maybe in moving the code, we can also gain inspiration to fix printing, too... ;)

Comment 8

[Sergei Dolgov]

Attachment: list of files to move

No PrintSettings yet, so our list is shorter

Comment 9

[Sergei Dolgov]

Attachment: patch

Doug, can you test it?
first, move files according to list;
second, apply the patch

Comment 10

[Sergei Dolgov]

Comment on attachment 211851 [details] [diff] [review]
patch

oops, patch is unsufficient. It does not reflect changes in widget.
looks like file should be moved first in cvs tree.

Comment 11

[Sergei Dolgov]

files moved:
 cvs commit -m'[BeOS]Bug 327046. Moving printing to widget' nsDeviceContextSpecB.cpp nsDeviceContextSpecB.h nsDeviceContextSpecFactoryB.cpp nsDeviceContextSpecFactoryB.h nsPrintOptionsBeOS.cpp nsPrintOptionsBeOS.h
Enter passphrase for key '/boot/home/.ssh/id_dsa':
RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.cpp,v
done
Checking in nsDeviceContextSpecB.cpp;
/cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.cpp,v  <--  nsDeviceContextSpecB.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.h,v
done
Checking in nsDeviceContextSpecB.h;
/cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecB.h,v  <--  nsDeviceContextSpecB.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.cpp,v
done
Checking in nsDeviceContextSpecFactoryB.cpp;
/cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.cpp,v  <--  nsDeviceContextSpecFactoryB.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.h,v
done
Checking in nsDeviceContextSpecFactoryB.h;
/cvsroot/mozilla/widget/src/beos/nsDeviceContextSpecFactoryB.h,v  <--  nsDeviceContextSpecFactoryB.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.cpp,v
done
Checking in nsPrintOptionsBeOS.cpp;
/cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.cpp,v  <--  nsPrintOptionsBeOS.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.h,v
done
Checking in nsPrintOptionsBeOS.h;
/cvsroot/mozilla/widget/src/beos/nsPrintOptionsBeOS.h,v  <--  nsPrintOptionsBeOS.h
initial revision: 1.1
done 

Comment 12

[Sergei Dolgov]

Attachment: patch for both gfx and widget

second take.

Comment 13

[Sergei Dolgov]

removed files from gfx
cvs ci -m'[BeOS]Bug 327046. Moving printing to widget'
cvs commit: Examining .
Enter passphrase for key '/boot/home/.ssh/id_dsa':
Checking in Makefile.in;
/cvsroot/mozilla/gfx/src/beos/Makefile.in,v  <--  Makefile.in
new revision: 1.29; previous revision: 1.28
done
Removing nsDeviceContextSpecB.cpp;
/cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecB.cpp,v  <--  nsDeviceContextSpecB.cpp
new revision: delete; previous revision: 1.34
done
Removing nsDeviceContextSpecB.h;
/cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecB.h,v  <--  nsDeviceContextSpecB.h
new revision: delete; previous revision: 1.18
done
Removing nsDeviceContextSpecFactoryB.cpp;
/cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecFactoryB.cpp,v  <--  nsDeviceContextSpecFactoryB.cpp
new revision: delete; previous revision: 1.17
done
Removing nsDeviceContextSpecFactoryB.h;
/cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecFactoryB.h,v  <--  nsDeviceContextSpecFactoryB.h
new revision: delete; previous revision: 1.9
done
Checking in nsGfxFactoryBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsGfxFactoryBeOS.cpp,v  <--  nsGfxFactoryBeOS.cpp
new revision: 1.27; previous revision: 1.26
done
Removing nsPrintOptionsBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsPrintOptionsBeOS.cpp,v  <--  nsPrintOptionsBeOS.cpp
new revision: delete; previous revision: 1.2
done
Removing nsPrintOptionsBeOS.h;
/cvsroot/mozilla/gfx/src/beos/nsPrintOptionsBeOS.h,v  <--  nsPrintOptionsBeOS.h
new revision: delete; previous revision: 1.2
done 

Comment 14

[Sergei Dolgov]

looks like did widget commit (to add new files) against already modified widget/src/beos and gfx/src/beos

So, patch is here rather to reflect changes than to apply:)

So, after checkout fo those folders, only configure is required, to create Makefile-s from Makefile.in-s

Comment 15

[Doug Shelton]

Attachment: terminal error output after moving files and applying 2nd patch

I think we're closer, fyysik, but not there yet.  Building now fails in widget, not gfx.  Attachment shows console output.

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 211853 [details] [diff] [review]
patch for both gfx and widget

mozilla/widget/src/beos/nsWidgetFactory.cpp
+  { "BeOS PrintSettings Service",
+  	NS_PRINTSETTINGSSERVICE_CID,
+  	"@mozilla.org/gfx/printsettings-service;1",
+  	nsPrintOptionsBeOSConstructor },

this is indented wrongly

r=biesi, looks ok, but I didn't review it very closely.

Comment 17

[Sergei Dolgov]

Doug
1)I don't see terminal output, but patch text there.
2)try to just checkout bot folders from cvs tree(gfx/src/beos and widget/src/beos) and modify Makefile-s in both according Makefile.in respective files. Maybe there is need to wait a bit, until changes in main cvs server reach cvs-mirrors (you get files from mirrors with anonymous cvs-account)

Comment 18

[Christian :Biesinger (don't email me, ping me on IRC)]

> and modify Makefile-s in both according Makefile.in 

Makefile should be automatically updated when Makefile.in changes.

Comment 19

[Sergei Dolgov]

Comment 18:
Without configure ?

Comment 20

[Doug Shelton]

Attachment: terminal error output after moving files and applying 2nd patch - really!

Comment 21

[Sergei Dolgov]

cvs commit -m'[BeOS]Bug 327046. Moving printing to widget. Adding nsPrintdBeOS.h'                                                                             cvs commit: Examining .
Enter passphrase for key '/boot/home/.ssh/id_dsa':
Checking in Makefile.in;
/cvsroot/mozilla/widget/src/beos/Makefile.in,v  <--  Makefile.in
new revision: 1.52; previous revision: 1.51
done
RCS file: /cvsroot/mozilla/widget/src/beos/nsPrintdBeOS.h,v
done
Checking in nsPrintdBeOS.h;
/cvsroot/mozilla/widget/src/beos/nsPrintdBeOS.h,v  <--  nsPrintdBeOS.h
initial revision: 1.1
done
Checking in nsWidgetFactory.cpp;
/cvsroot/mozilla/widget/src/beos/nsWidgetFactory.cpp,v  <--  nsWidgetFactory.cpp
new revision: 1.36; previous revision: 1.35
done 

Comment 22

[Sergei Dolgov]

 cvs ci -m'[BeOS]Bug 327046. Moving printing to widget. nsPrintdBeOS.h'        cvs commit: Examining .                                                         Enter passphrase for key '/boot/home/.ssh/id_dsa':                              Removing nsPrintdBeOS.h;
/cvsroot/mozilla/gfx/src/beos/nsPrintdBeOS.h,v  <--  nsPrintdBeOS.h
new revision: delete; previous revision: 1.7
done 

Comment 23

[Sergei Dolgov]

Doug, move
nsPrintdBeOS.h
from gfx to widget and try again

Comment 24

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #19)
> Comment 18:
> Without configure ?

yes

Comment 25

[Doug Shelton]

(In reply to comment #23)
> Doug, move
> nsPrintdBeOS.h
> from gfx to widget and try again
>

to be safe, I deleted gfx/src/beos and widget/src/beos and did CVS updates to pull the latest.  Debug version built clean and seems to run OK.  New strange problem, though:  icons in the download manager are corrupted.  

Comment 26

[Sergei Dolgov]

Will close it when Doug reports success in building both gfx and widget for new full source checkout (not only those thwo dirs)

Comment 27

[Sergei Dolgov]

closing