Closed Bug 327243 Opened 18 years ago Closed 18 years ago

[FIX]Don't expose securityCompareURIs() on nsIScriptSecurityManager

Categories

(Core :: Security: CAPS, defect, P2)

Product:
Core
Component:
Security: CAPS
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

Fix
13.37 KB, patch
Details | Diff | Splinter Review
Same as diff -w
11.61 KB, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review 
Bug 325816 removes the one caller of securityCompareURIs() outside of caps.  Should that method just become a private nsScriptSecurityManager method?

That said, why does this even exist?  If it's because the error reporting done by checkSameOriginURI is undesirable, we should just remove said error reporting, imo.
Flags: blocking1.9a1?
We should just do this.  Replace it with a principal version if we want to affect error-reporting behavior....
Flags: blocking1.9a1? → blocking1.9-
Summary: Should securityCompareURIs() be exposed on nsIScriptSecurityManager? → Don't expose securityCompareURIs() on nsIScriptSecurityManager
Whiteboard: [wanted-1.9]
Attached patch Fix — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Same as diff -w
        — 
          — Splinter Review
      

    


  

        Attachment #245355 -
        Flags: superreview?(jst)

        Attachment #245355 -
        Flags: review?(jst)

    
  
Assignee: dveditz → bzbarsky
Priority: -- → P2
Summary: Don't expose securityCompareURIs() on nsIScriptSecurityManager → [FIX]Don't expose securityCompareURIs() on nsIScriptSecurityManager
Target Milestone: --- → mozilla1.8.1

    
  
Blocks: JEP/caps

    
    

    
  
Comment on attachment 245355 [details] [diff] [review]
Same as diff -w

r+sr=jst

        Attachment #245355 -
        Flags: superreview?(jst)

        Attachment #245355 -
        Flags: superreview+

        Attachment #245355 -
        Flags: review?(jst)

        Attachment #245355 -
        Flags: review+

    
    

    
  
Fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.8.1 → mozilla1.9alpha

    
  
Flags: wanted1.9+
Whiteboard: [wanted-1.9]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: