Closed Bug 327305 Opened 15 years ago Closed 15 years ago

Include Gecko version and build ID in extension description

Categories

(Core Graveyard :: XForms, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: allan, Assigned: allan)

References

()

Details

(Keywords: fixed1.8.0.4, fixed1.8.1)

Attachments

(1 file)

I think we should include the Gecko version and the build ID in the extension description, so that users easier can figure out whether the extension they have installed actually mathces their product, and which date it's from.
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
This also includes a targetApplication for SeaMonkey.
Attachment #211996 - Flags: review?(doronr)
Attachment #211996 - Flags: review?(doronr) → review+
Attachment #211996 - Flags: review?(aaronr)
Attachment #211996 - Flags: review?(aaronr) → review+
(In reply to comment #1)
> Created an attachment (id=211996) [edit]

Checked in to trunk.

As this also adds a targetApplication tag for SeaMonkey, somebody should probably verify that it still works on SeaMonkey. Any volunteers? :)
Whiteboard: xf-to-branch
If you tell me how I could test this, I'll be glad to test it and report back here.
(In reply to comment #3)
> If you tell me how I could test this, I'll be glad to test it and report back
> here.

I could also do it myself, but I'm lazy and forgets stuff :)

Just download a nightly trunk build of SeaMonkey and the XForms extension, use a clean profile and see if you can install the extension and run one of the sample forms.

You have to wait for the next cycle of builds though. So after Saturday or Sunday is probably best.
What if I built my own SM + XF? :)
Followed instructions from XForms Project page (canvas, xforms and schema-validation options added). ;)
(In reply to comment #5)
> What if I built my own SM + XF? :)
> Followed instructions from XForms Project page (canvas, xforms and
> schema-validation options added). ;)

Ok, then :) It works then I guess?
Blocks: 326556
(In reply to comment #6)
> Ok, then :) It works then I guess?
 
Seems so... :)
If you have more bugs with SM testing needs, please add me to CC list and write down some exact testing instruction: I'll be glad to report back!
(In reply to comment #7)
> (In reply to comment #6)
> > Ok, then :) It works then I guess?
> 
> Seems so... :)
> If you have more bugs with SM testing needs, please add me to CC list and write
> down some exact testing instruction: I'll be glad to report back!

Ok. I'll keep that in mind. Thanks for testing it.
How about pushing this to branches too? When we reach 1.0 we should kill it on releases, but for now it makes sense I think.
(In reply to comment #9)
> How about pushing this to branches too? When we reach 1.0 we should kill it on
> releases, but for now it makes sense I think.
> 

I don't really mind if it moves to the branches as long as you open up a bug to make sure that we remove it before 1.0 ships.
Blocks: 330433
(In reply to comment #10)
> (In reply to comment #9)
> > How about pushing this to branches too? When we reach 1.0 we should kill it on
> > releases, but for now it makes sense I think.
> > 
> 
> I don't really mind if it moves to the branches as long as you open up a bug to
> make sure that we remove it before 1.0 ships.

Done so. I'll just wait until after 1.5.0.2 hits the streets.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: 332853
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.