327541 - Can't build Firefox with --with-libxul-sdk and places together

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Sylvain Pasche]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.1) Gecko/20060210 Ubuntu/dapper Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060216 Firefox/1.6a1

When building firefox with places and --with-libxul-sdk, there is an error in browser/browser/components/build:

make[1]: *** No rule to make target `../../../db/morkreader/libmorkreader_s.a', needed by `libbrowsercomps.so'.  Stop.

coming from:

ifdef MOZ_PLACES
EXTRA_DSO_LDOPTS += $(DEPTH)/db/morkreader/$(LIB_PREFIX)morkreader_s.$(LIB_SUFFIX)
endif

The problem may be that morkreader is in tear_50 which is not being built when using libxul.

Manually running make in mozilla/db fixes the issue by the way.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Sylvain Pasche]

s/tear_50/tier_50/

I'm too emotional ;-)

Comment 2

[Benjamin Smedberg]

Care to write a patch? You probably need to make it use GECKO_DIST.

Comment 3

[Sylvain Pasche]

I tried commenting the EXTRA_DSO_LDOPTS against libmorkreader_s.a

but I'm a bit stuck:

I see that morkreader is linked into libxul.so and that libbrowsercomps.so
 links against it:

ldd libbrowsercomps.so|grep libxul
        libxul.so => not found

But when loading the component, it fails to locate a symbol:

libbrowsercomps.so: undefined symbol: _ZNK12nsMorkReader14NormalizeValueER9nsCString

Which is defined in libxul.so:

nm xulrunner/dist/bin/libxul.so |grep _ZNK12nsMorkReader14NormalizeValueER9nsCString
002983ea t _ZNK12nsMorkReader14NormalizeValueER9nsCString

Any idea why the component fails to find it ? I'm a bit new to all this stuff.

Comment 4

[Sylvain Pasche]

I guess the problem is that the symbol has local scope in libxul.so.

What's strange is that it does not do the "symbol not found" on x86_64 architecture.

Comment 5

[Benjamin Smedberg]

This is probably easier fixed by bug 321219: unless we take that patch we're going to end up carrying around two copies of morkreader anyway (one for xulrunner, one for firefox).

Comment 6

[buovjaga]

bug 321219 was fixed in 2006-07-18
Let's close as fixed.