327596 - Minor status bar behavior improvement

Status: RESOLVED WORKSFORME

(SeaMonkey :: UI Design, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

I filed this because bug 104532 has too many comments.

I played around with some code this morning, and we can improve the current behavior a bit - right now, if a page sets the status bar text, you switch tabs, and you switch back to the previous tab you get an empty status bar.  It's actually possible to restore the text that was there before.  Patch in a moment.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: restore previous text

Comment 2

[Wayne Woods]

(In reply to comment #0)
> It's actually possible to restore the text that was there before.

Is that really "the text that was there before", or is it the current status text for that tab? If the former, it could be as erroneous as any other status message by the time the user switches back. Just checking.

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #2)
> (In reply to comment #0)
> > It's actually possible to restore the text that was there before.
> 
> Is that really "the text that was there before", or is it the current status
> text for that tab? If the former, it could be as erroneous as any other status
> message by the time the user switches back. Just checking.

Whatever it would be if you had not switched away to another tab.

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #0)
> > > It's actually possible to restore the text that was there before.
> > 
> > Is that really "the text that was there before", or is it the current status
> > text for that tab? If the former, it could be as erroneous as any other status
> > message by the time the user switches back. Just checking.
> 
> Whatever it would be if you had not switched away to another tab.

...*almost*.  You don't get stuff like "Done." or "Waiting for..."

Comment 5

[[e-mail]]

Comment on attachment 212194 [details] [diff] [review]
restore previous text

Only two problems:
1. content.status isn't reliable (think frames).
2. onLocationChange also fires for location changes!

Comment 6

[Serge Gautherie (:sgautherie)]

Chris,

Are you still working on this ?

***

New code location is
<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/suite/browser/nsBrowserStatusHandler.js&rev=1.77&mark=315-320#278>

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Nope.

Comment 8

[Philip Chee]

Sinc Bug 104532 is WFM, this one is too.

Comment 9

[[e-mail]]

Misak's patch in bug 583317 goes some way to addressing part of this.