327632 - time restrictions for day and week view only work between 0 and 23 o'clock

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Christoph Eßer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

While the time restrictions in general now work correctly, it is not possible to view the events in day view and week view up to 12 pm. This is very annoying for people like me who want to have the whole day shown.

Reproducible: Always

Steps to Reproduce:
1. Go to Tools->Preferences->Lightning->Week View
2. Set Start time to 0 and End Time to 24
3. Go to week view or day view

Actual Results:  
The old time preferences are kept.

Expected Results:  
The whole day should be displayed.

Comment 1

[Stefan Sitter [:ssitter]]

Confirmed. If you enter a end time of '24' and press 'OK' the following error is displayed in javascript console:

Error: [Exception... "'Illegal value' when calling method: 
[nsIObserver::observe]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" 
location: "JS frame :: chrome://global/content/bindings/preferences.xml :: 
set_valueFromPreferences :: line 268"  data: no]

New settings are not applied.

Comment 2

[Stefan Sitter [:ssitter]]

Day and Week view observe the property 'calendar.view.defaultendhour'
http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-decorated-day-view.xml#112
http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-decorated-week-view.xml#112

If the property changes they call setStartEndMinutes(). This method throws an error if the value of EndMinutes >= 24*60:
http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-multiday-view.xml#92
http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-multiday-view.xml#378
http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-multiday-view.xml#1989

Possibles solutions:
1) Allow EndMinutes == 24*60 value for multiday views or
2) Set EndMinutes to (24*60)-1 if they are greater than 24*60

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: setStartEndMinutes: allow aEndMin==24*60

Patch uses proposed solution 1, allow 24:00 as end hour for view. Found no problems when testing with events that start/stop at 00:00 or span multiple days.

Comment 4

[Joey Minta]

Comment on attachment 212375 [details] [diff] [review]
setStartEndMinutes: allow aEndMin==24*60

I have 2 concerns here.  (1) From reading over the code, I think we're ok, but I want to make sure someone has tested the nightmare scenario: 0-length events scheduled at midnight, to make sure they don't appear in two columns.

(2) How will this patch interact with the patch on Bug 323093?  That's an 0.1 blocker that I don't want to disrupt at this stage.  I'll CC tbe in a minute for his thoughts.

Comment 5

[Stefan Sitter [:ssitter]]

Comment on attachment 212375 [details] [diff] [review]
setStartEndMinutes: allow aEndMin==24*60

Remove review request until it is clear if this will be solved in Bug 323093 or not.

Comment 6

[Stefan Sitter [:ssitter]]

Fixed by the patch that landed in bug 323093 yesterday.