Closed Bug 327662 Opened 20 years ago Closed 19 years ago

"Currently selected day" in unifinder doesn't update on selection

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: robin.edrenius, Assigned: jminta)

References

Details

Attachments

(1 file)

implement 'dayselect' event
6.70 KB, patch
mvl
: first-review+
Details | Diff | Splinter Review
If you choose "Currently selected day" as the unifinder-filter you see the events of the day that is selected when you choose to that filter. However, if you change day, the unifinder doesn't update, you have to choose another filter and then choose back to "Currently selected day" to update it. Broken by the switch to the new views.
This patch implements a 'dayselect' event that will be fired whenever the selected day in the views is changed. My guess is that in the future we'll want to begin firing additional events from the views as well ('refresh', etc), but for now, this event is sufficient to fix the bug. The unifinder listens for it, and refreshes its display, if appropriate.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #214508 - Flags: first-review?(mvl)
Comment on attachment 214508 [details] [diff] [review] implement 'dayselect' event >+ <method name="fireEvent"> >+ <parameter name="aEventName"/> >+ <body><![CDATA[ Nit: fix indenting. (also in the copy in the other xml) >+function unifinderOnDaySelect() { >+ var filter = document.getElementById("event-filter-menulist").selectedItem.value; >+ if (filter == "current") { >+ refreshEventTree(); >+ } >+} That function was slightly confusing to me at first look. It wasn't clear that filter is the current filter. maybe make it: + var filterList = document.getElementById("event-filter-menulist"); + if (filter.selectedItem.value == "current") { I didn't read all the code, but shouldn't there be some old code (that listened to the old views) that can be removed now? Or is that already done? r=mvl. Your choice if you address that unifinderOnDaySelect() nit.
Attachment #214508 - Flags: first-review?(mvl) → first-review+
Blocks: sunbird-0.3a2
Patch checked in. The old code was contained in calendarWindow, and was removed with the switch to the new views.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060909 Calendar/0.3a2+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: