327694 - "ASSERTION: Failed to position iterator!" getting link.text for link that has been removed from document

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

###!!! ASSERTION: Failed to position iterator!: 'NS_SUCCEEDED(rv)', file mozilla/content/base/src/nsContentIterator.cpp, line 991

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

The "Check to see if the node falls within the traversal range" part
of nsContentIterator::PositionAt requires that the node has a parent,
if not then we bail put at line 1106 and Last() will assert:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/base/src/nsContentIterator.cpp&rev=1.74&root=/cvsroot&mark=1063-1107#1046
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/base/src/nsContentIterator.cpp&rev=1.74&root=/cvsroot&mark=130-145#130

Comment 3

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Same as first patch with some additional cleanups:
  * prune #includes
  * avoid QI to nsIDOMNode
  * use nsPreContentIterator in nsHTMLAnchorElement::GetText() which avoids
    finding the deepest node of the first child which we're not interested
    in anyway
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/base/src/nsContentIterator.cpp&rev=1.74&root=/cvsroot&mark=361-362#346

Comment 4

[Mats Palmgren (inactive)]

BTW, maybe we should wrap the whole "Check to see if the node falls within the traversal range" block in #NS_DEBUG since we assert on it?

Comment 5

[Johnny Stenback (:jst)]

But that block of code also sets iterator state (mIsDone), so we don't want that whole block of code to be debug only do we?

Comment 6

[Jesse Ruderman]

Mats, are you planning to request approval and check this in?

Comment 7

[Carsten Book [:Tomcat]]

###!!! ASSERTION: Failed to position iterator!: 'NS_SUCCEEDED(rv)', file c:/Debug/mozilla/content/base/src/nsContentIterator.cpp, line 997

was just running into this assertion while abcnews.com was loaded on windows debug build.

Comment 8

[Jesse Ruderman]

Still happens on trunk.

Mats, you don't need a= to land stuff now ;)

Comment 9

[Mats Palmgren (inactive)]

Attachment: rev. 2 updated to tip

The deCOMtamination part of the patch has already been done in trunk code,
otherwise it's the same.

Comment 10

[Mats Palmgren (inactive)]

http://hg.mozilla.org/mozilla-central/rev/25876aad27d8