327738 - Reset Camino doesn't reset minimized windows

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[eric_apple]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060214 Camino/1.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060214 Camino/1.0

When performing a "reset Camino" function, minimized windows are not reset and are left open.  Previous version of Camino would reset rest these windows as well.

Note: Also using CamiTools but have not tested this bug while uninstalling CamiTools to see if there is a difference.

Reproducible: Always

Steps to Reproduce:
1. Open window A and minimize it
2. Open window B and then choose reset camino
3. Currrentt window is rest but others are left open and on the page viewed prior to reset camino being used.

Comment 1

[Chris Lawson (gone)]

Confirming with Camino 1.0 and a fresh profile. We probably forgot to look for minimised windows when we did those Reset Camino tweaks a month or so ago.

cl

Comment 2

[Simon Fraser [no longer active]]

resetBrowser: has this in the loop:

        if ([curWindow isVisible])
          [curWindow performClose:self];

Either we need to remove the -isVisible check, or add isMinimized. I was trying to eliminated places in the code where we can close partially constructed windows.

Comment 3

[froodian (Ian Leue)]

Attachment: Patch

Comment 4

[Chris Lawson (gone)]

Comment on attachment 226018 [details] [diff] [review]
Patch

r=me, fwiw.

Guess this can go in. :)

cl

Comment 5

[Nick Kreeger]

Fixed trunk and branch

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

v. on the trunk

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This applies on 180 still, and we should take it for 1.0.3.

Comment 8

[Nick Kreeger]

Landed on the MOZILLA_1_8_0_BRANCH

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Someone please verify tomorrow and changed fixed1.8.0.7 to verified1.8.0.7.