The default bug view has changed. See this FAQ.

Support configurable preflight/postflight actions in client.mk

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Mark Mentovai, Assigned: Mark Mentovai)

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
PowerPC
Mac OS X
fixed1.8.0.2, fixed1.8.1
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.0.2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [camino-1.0])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

11 years ago
This is a requirement for Mac universal builds.  The universal build process will be driven entirely "hands-off" by client.mk.  A build will be done for each architecture using the multi-project support introduced in bug 307311 and cross-compile support from bug 322578.  After builds for both architectures are complete, they will be merged into a universal binary using the tools in bug 324855.  In order for client.mk to manage that process directly as well, it needs to support configurable postflight actions.
(Assignee)

Comment 1

11 years ago
This patch will also introduce build date harmonization, which is technically a separate issue but also involves patches to client.mk.  This feature enables a client.mk configurable, MOZ_BUILD_DATE_DIR, to be set to an OBJDIR from which the bdate or gbdate will be extracted and used as MOZ_BUILD_DATE.  This is needed to ensure that the build IDs will be identical for both halves of Mac universal binaries.
(Assignee)

Comment 2

11 years ago
Created attachment 212394 [details] [diff] [review]
Configurable preflight/postflight actions and build date harmonization

This introduces the following new client.mk tunables:

+#   MOZ_BUILD_DATE_DIR   - OBJDIR whose MOZ_BUILD_DATE is to be copied
+#   MOZ_PREFLIGHT_ALL  } - Makefiles to run before any project in
+#   MOZ_PREFLIGHT      }   MOZ_BUILD_PROJECTS, before each project, after
+#   MOZ_POSTFLIGHT     }   each project, and after all projects; these
+#   MOZ_POSTFLIGHT_ALL }   variables contain space-separated lists
Attachment #212394 - Flags: review?(benjamin)
(Assignee)

Comment 3

11 years ago
An older version of this patch was used for the Camino 1.0 release.
Whiteboard: [camino-1.0]
(Assignee)

Updated

11 years ago
Blocks: 327848
(Assignee)

Updated

11 years ago
Flags: blocking1.8.0.2?
Comment on attachment 212394 [details] [diff] [review]
Configurable preflight/postflight actions and build date harmonization

for preflight_all and postflight_all, I'd like to pass "MOZ_BUILD_PROJECTS=$(MOZ_BUILD_PROJECTS)" as well. See review comments in bug 327848 for my reasoning (not yet posted of course).

r+ on the preflight/postflight stuff.

I'd like to discuss the builddate stuff with you separately, in particular  I don't understand the sequence of events here and I'd like to reuse bdate.pl instead of inventing a new script.
Attachment #212394 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

11 years ago
Created attachment 212620 [details] [diff] [review]
As checked in

As checked in on the trunk, with the bdate stuff ripped out.  bdate will be handled in a new bug.
Attachment #212394 - Attachment is obsolete: true
Attachment #212620 - Flags: approval1.8.0.2?
Attachment #212620 - Flags: approval-branch-1.8.1?(benjamin)
Comment on attachment 212620 [details] [diff] [review]
As checked in

a=me once the tboxen cycle green
Attachment #212620 - Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
(Assignee)

Comment 7

11 years ago
Created attachment 212621 [details] [diff] [review]
As checked in

Added MOZ_BUILD_PROJECTS pass.
Attachment #212620 - Attachment is obsolete: true
Attachment #212621 - Flags: approval1.8.0.2?
Attachment #212621 - Flags: approval-branch-1.8.1?(benjamin)
Attachment #212620 - Flags: approval1.8.0.2?
(Assignee)

Updated

11 years ago
Attachment #212621 - Flags: approval-branch-1.8.1?(benjamin)
Flags: blocking1.8.0.2? → blocking1.8.0.2+
So this is FIXED on trunk, right? If it landed on the 1.8 branch please add the fixed1.8.1 keyword.
Comment on attachment 212621 [details] [diff] [review]
As checked in

approved for 1.8.0 branch, a=dveditz
Attachment #212621 - Flags: approval1.8.0.2? → approval1.8.0.2+
(Assignee)

Comment 10

11 years ago
Holding branch checkins for landing of dependency, bug 307311.
(Assignee)

Comment 11

11 years ago
Checked in on HEAD, MOZILLA_1_8_BRANCH, and MOZILLA_1_8_0_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.0.2, fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.