327845 - typo: calStorageCalendar.writeAttendees reference to undefined property flags

Status: RESOLVED FIXED

(Calendar :: Provider: Local Storage, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: 20060218

  Error: reference to undefined property flags
  Source File: file:///C:/Program%20Files/Sunbird/components/calStorageCalendar.js
  Line: 1604

This line is left over from a previous version and should have been removed in a prior edit; the HAS_ATTENDEES value is now returned instead.

Reproducible: Always

Comment 1

[gekacheka]

Attachment: remove leftover line referring to 'flags'

(patch -l -p 2 -i file.patch)

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Is this a dataloss bug?  i.e. does the typo cause it to throw, or does execution continue with an error message?

Comment 3

[gekacheka]

This bug throws the error shown, so an item with attendees cannot be saved to a calStorageProvider.  I'm not sure whether that qualifies as dataloss, since you can't save data the first time.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Fixed.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 212407 [details] [diff] [review]
remove leftover line referring to 'flags'

r=dmose