Closed Bug 327863 Opened 18 years ago Closed 18 years ago

seamonkey-config should not be shipped

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mark, Assigned: mark)

Details

(4 keywords)

Attachments

(1 file)

Don't ship seamonkey-config
771 bytes, patch
Biesinger
: review+
Biesinger
: approval-seamonkey1.0.1+
kairo
: approval-seamonkey1.1a+
Details | Diff | Splinter Review 
Well, not if you guys want to release a Mac universal binary, anyway.

The seamonkey-config script understandably differs slightly between architectures when doing a cross build.  This causes the script that merges everything into a universal binary to fail.

    
    

    
  
Comment on attachment 212426 [details] [diff] [review]
Don't ship seamonkey-config

I don't know which of the SeaMonkey people is best to review this, feel free to pass off on another victim!

        Attachment #212426 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 212426 [details] [diff] [review]
Don't ship seamonkey-config

r=biesi

        Attachment #212426 -
        Flags: review?(neil) → review+

    
    

    
  
Requesting blocking-seamonkey1.1a.

If SeaMonkey 1.1 is going to be universal, this needs to get on the branch.
Flags: blocking-seamonkey1.1a?
Flags: blocking-seamonkey1.1a? → blocking-seamonkey1.1a+

    
    

    
  
Checked in on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 212426 [details] [diff] [review]
Don't ship seamonkey-config

Not sure if you guys want this for 1.0.1.  Other 1.8.0-branch products will be buildable (and released) as universal.

        Attachment #212426 -
        Flags: approval-seamonkey1.1a?

        Attachment #212426 -
        Flags: approval-seamonkey1.0.1?

    
    

    
  
Comment on attachment 212426 [details] [diff] [review]
Don't ship seamonkey-config

a=me for 1.1; first a=me for 1.0.1 as well, need a second one to go still for that one.

        Attachment #212426 -
        Flags: approval-seamonkey1.1a? → approval-seamonkey1.1a+

    
    

    
  
Comment on attachment 212426 [details] [diff] [review]
Don't ship seamonkey-config

a=me for 1.0.1

        Attachment #212426 -
        Flags: approval-seamonkey1.0.1? → approval-seamonkey1.0.1+

    
    

    
  
and, thank you for taking care of SeaMonkey as well!

    
    

    
  
Checked in on 1_8 and 1_8_0 branches.  I wouldn't forget about you guys!

I've still got to fix bug 327864 before universal SeaMonkeys are ready to roll.
Keywords: fixed1.8.0.2, 
          
            fixed1.8.1

    
  
Keywords: fixed-seamonkey1.0.1

    
  
Keywords: fixed-seamonkey1.1a

          You need to log in
          before you can comment on or make changes to this bug.