327877 - multiple entries for same task are created in agenda when editing task.

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Matt]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: lightning /release date 20060219

Once a task has been created, if you then edit it in any manner, or mark it as completed, the agenda tab keeps adding it as a new entry. 

Reproducible: Always

Steps to Reproduce:
1. create a task and close it,
2. reopen task and make a modification, or mark it as complete/incomplete,
3. go back to agenda view adn observ that it now has two entries for the same thing,
4. repeat steps 1-3 a few times and observ a new entry is created each time.



Expected Results:  
1. when editing a task, additional entries should not be created.
2. marking a task as completed should have some impact on how it is displayed in the agenda view(i.e. a tick to identify it has been completed)

Comment 1

[Joey Minta]

Thanks for the bug report.  Can you tell me:

(1) What type of calendar are you using? (local, remote webdav, remote caldav)
(2) Does restarting the program have any effect on the number of instances appearing in the list?

Comment 2

[Stefan Sitter [:ssitter]]

Confirmed using Lightning 2006-02-20-07-trunk build on Linux and Lightning 2006-02-19-07-mozilla1.8 build on Windows 2000. I have tried with both storage calendar and a local ics calendar.

Every time you close the 'Edit Task' dialog a new entry is created in Agenda tab. (Todo tab works fine). After closing and restarting Thunderbird only one copy of the task is displayed (as expected).

Comment 3

[Joey Minta]

Attachment: remove obsolete calIEvent restriction

Originally, the agenda tree was written to only handle events.  Then some silly kid got the idea to make it handle tasks too, but forgot to remove this line from onDeleteItem.  This patch makes sure we delete tasks too when they're modified.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 213911 [details] [diff] [review]
remove obsolete calIEvent restriction

r=dmose; nice work!

Comment 5

[Joey Minta]

Patch checked in.