327991 - Simplify 3 central functions in nsIMAPGenericParser.cpp

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Hans-Andreas Engel]

The functions |CreateLiteral()|, |CreateQuoted()|, and |CreateParenGroup()| in |nsIMAPGenericParser| are somewhat lengthy and complex.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/imap/src/nsIMAPGenericParser.cpp&rev=1.51&mark=335-410,413-505,508-668#335

Part of that complexity resulted from some kludges needed to implement BODYSTRUCTURE parsing.  However, as Bug 312599 is now fixed, these kludges can be removed.

Comment 1

[Hans-Andreas Engel]

Attachment: Simplify CreateLiteral(), CreateQuoted(), and CreateParenGroup()

This patch should not change the behavior of the parser [except that now quoted strings with escaped characters are correctly handled in |CreateParenGroup()|; and null is returned if no closing quote is found in |CreateQuoted()|].

Note that in the old version of CreateLiteral(), |terminateLine| is always true (after fixing Bug 312599).

Comment 2

[Hans-Andreas Engel]

Attachment: Simplify CreateLiteral(), CreateQuoted(), and CreateParenGroup(), diff -upw8

Comment 3

[David :Bienvenu]

Comment on attachment 212551 [details] [diff] [review]
Simplify CreateLiteral(), CreateQuoted(), and CreateParenGroup()

thx, Hans-Andreas. Sorry for the delay.Looks good; I'll check this in.

Comment 4

[David :Bienvenu]

fixed on trunk