328036 - Flashbar does not flash

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Ria Klaassen (not reading all bugmail)]

Steps to reproduce:

1. Remove user_pref("accessibility.typeaheadfind.flashBar", 0); from prefs.js.
2. Start a trunk build and do ctrl+f.
3. The inputfield of the findbar is yellow and does not flash.
4. When you type something in the bar it stays yellow also when the search term is not found and because the text turns white it is hard to see what exactly Firefox didn't find.

Regression between 1.9a1_2005110105 and 1.9a1_2005110114.

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2005-11-01+04%3A00&maxdate=2005-11-01+14%3A00

Comment 1

[Ria Klaassen (not reading all bugmail)]

Attachment: screenshot flashbar

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch #1

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch #2

I think I like this one better.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Masayuki, do you have an opinion on which patch you prefer?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 212583 [details] [diff] [review]
patch #2

Index: toolkit/components/typeaheadfind/content/findBar.js

>-      this.mFlashFindBarTimeout = setInterval(this.flashFindBar, 500);
>+      this.mFlashFindBarTimeout = setInterval(this.flashFindBar, 500, this);

Oops, ignore this change in the second patch.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Mike Connor said, we should not use 'gFindBar.foo()' style in gFindBar.
Therefore, I used 'Timer Event Handlers' in the tail of the file.
See bug 313149 comment 9 and bug 313149 comment 12.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Patch rv1.0

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

checked-in to trunk.

This patch cannot go to 1.8.1, because bug 313149 is fixed only on trunk.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Fixed on the 1.8 branch by bug 313149.