328037 - JS_CallFunctionName should return the same as JS_CallFunctionValue

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Mads Bondo Dydensborg]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.2; Linux) KHTML/3.2.3 (like Gecko)
Build Identifier: cvs

If you look at the source to current CVS js, here is the last lines for JS_CallFunctionName:
    ok = js_InternalCall(cx, obj, fval, argc, argv, rval);
    LAST_FRAME_CHECKS(cx, ok);
    return JS_TRUE;
and, for JS_CallFunctionValue
    ok = js_InternalCall(cx, obj, fval, argc, argv, rval);
    LAST_FRAME_CHECKS(cx, ok);
    return ok;

I think JS_CallFunctionName should return ok, not JS_TRUE. This is based on reading the docs. The difference is most clear, if your code throws an unhandled exception.

A work around is to call JS_GetProperty for the name, then call JS_CallFunctionValue. This will allow calls to function that throws, to return JS_FALSE.


Reproducible: Always

Comment 1

[Brendan Eich [:brendan]]

Whoops -- easily fixed.  Thanks for pointing this typo out.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Trivial, I'm checking in.

/be

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 212684 [details] [diff] [review]
fix 

Yes.

Comment 4

[Brendan Eich [:brendan]]

Fixed on trunk.

/be

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 212684 [details] [diff] [review]
fix 

approved for 1.8.0 branch, a=dveditz

Comment 6

[Brendan Eich [:brendan]]

Fixed on 1.8* branches.

/be

Comment 7

[Dave Liebreich [:davel]]

Please provide guidance for testing this fix.